LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Theodore Tso <tytso@MIT.EDU>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Felipe Balbi <felipebalbi@users.sourceforge.net>,
	tiwai@suse.de, Andrew Morton <akpm@linux-foundation.org>,
	"Klaus S. Madsen" <ksm@hjernemadsen.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: T61P sound issue
Date: Tue, 5 Feb 2008 21:25:17 -0500	[thread overview]
Message-ID: <20080206022517.GB27119@mit.edu> (raw)
In-Reply-To: <Pine.LNX.4.64.0802052207330.30873@twin.jikos.cz>

On Tue, Feb 05, 2008 at 10:16:08PM +0100, Jiri Kosina wrote:
> [ added Takashi ]
> 
> On Tue, 5 Feb 2008, Felipe Balbi wrote:
> 
> > > > > > Could anyone make T61P's ICH8 sound controller to work properly?
> > Good that there's a lot of people using T61p, it's a good machine.
> > I'll upgrade my BIOS and try again the crappy sound.
> 
> I have just bought X61s, and it seems to have the very same soundcard as 
> your T61p does:
>
> The sound also doesn't work with 2.6.24 (tried modprobing the 
> snd-hda-intel with 'model=thinkpad', didn't make any difference). The 
> mixer settings seem to be correct, but there is no sound.
> 

Hmm.. sound works just fine for me on my X61s (model #7668-CTO)
running 2.6.24.  

I do have this private patch applied --- maybe it makes a difference
for you?  I don't think it should make a difference, but....

						- Ted


commit c9001b03378048cad0f5c4f87dbb97fff1f80c51
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Wed Jan 9 05:14:14 2008 -0500

    hda_intel suspend latency: shorten codec read
    
    not sleeping for every codec read/write but doing a short udelay and
    a conditional reschedule has cut suspend+resume latency by about 1
    second on my T60.
    
    The patch also fixes the unexpected codec-connection errors that
    happen more often in the new power-save mode:
        http://lkml.org/lkml/2007/11/8/255
        http://bugzilla.kernel.org/show_bug.cgi?id=9332
    
    This had been applied, and then reverted due to problems.  See commit
    d238998fbfa49f30b02f0a5de5294ca53c58348c
    
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Acked-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 3fa0f97..62b9fb3 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -555,7 +555,8 @@ static unsigned int azx_rirb_get_response(struct hda_codec *codec)
 		}
 		if (!chip->rirb.cmds)
 			return chip->rirb.res; /* the last value */
-		schedule_timeout_uninterruptible(1);
+		udelay(10);
+		cond_resched();
 	} while (time_after_eq(timeout, jiffies));
 
 	if (chip->msi) {

  parent reply	other threads:[~2008-02-06  2:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-27 13:49 Felipe Balbi
2008-02-05  3:40 ` Andrew Morton
2008-02-05  3:43   ` Andrew Morton
2008-02-05 11:58     ` Takashi Iwai
2008-02-05 11:36   ` Klaus S. Madsen
2008-02-05 18:22     ` Andrew Morton
2008-02-05 21:04       ` Felipe Balbi
2008-02-05 21:16         ` Jiri Kosina
2008-02-05 21:25           ` Felipe Balbi
2008-02-06  2:25           ` Theodore Tso [this message]
2008-02-06  8:11             ` Jiri Kosina
2008-02-06 13:53               ` Theodore Tso
2008-02-06 13:56                 ` Jiri Kosina
2008-02-06 22:20                   ` Felipe Balbi
2008-02-06  7:10           ` Takashi Iwai
2008-02-06 10:06             ` Jiri Kosina
2008-02-06 22:33   ` ggriffin10
2008-02-06 22:40     ` Felipe Balbi
2008-02-07 12:06 Lukas Hejtmanek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080206022517.GB27119@mit.edu \
    --to=tytso@mit.edu \
    --cc=akpm@linux-foundation.org \
    --cc=felipebalbi@users.sourceforge.net \
    --cc=jikos@jikos.cz \
    --cc=ksm@hjernemadsen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    --subject='Re: T61P sound issue' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).