LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: schwidefsky@de.ibm.com, benh@kernel.crashing.org,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [patch 2/3] CONFIG_HIGHPTE vs. sub-page page tables.
Date: Wed, 6 Feb 2008 10:15:25 +0100	[thread overview]
Message-ID: <20080206091525.GA26358@elte.hu> (raw)
In-Reply-To: <20080206010947.7b3e9d5e.akpm@linux-foundation.org>


* Andrew Morton <akpm@linux-foundation.org> wrote:

> > > urgh, well, thanks for trying.  If there's significant risk factor 
> > > (or hassle) in fixing the macros then I'd suggest we not do it for 
> > > now - it's a separate project.
> > 
> > I'm still at it. I does make sense to convert the damn macros to 
> > inline functions. The question now is the order of things, the macro 
> > cleanup first or the sub-page page tables first? I would prefer the 
> > sub-page page tables first since that code has been hanging around 
> > in -mm for a while and could go upstream after I regenerated the 
> > patch and test compiled it again. We do need it for KVM and we want 
> > to push our KVM patches for s390 soon.
> 
> I'd suggest do the macro ceanup later.  That's the sort of thing which 
> we can/should trickle through arch maintainers.

note that there are ways to stage even API extensions like adding an 
extra 'struct mm_struct *mm' to macros. It takes a temporary ugliness 
like:

 #define __EXTRA_MM_ARG_DEF			, struct mm_struct *mm
 #define __EXTRA_MM_ARG_VAL(arg)		, (arg)

which converted architectures redefine.

and at the end eliminate these compatibility macros from the core, once 
all arches have converted.

so we _could_ stage even something like this.

	Ingo

  reply	other threads:[~2008-02-06  9:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-12 14:30 [patch 0/3] page table changes schwidefsky
2007-11-12 14:30 ` [patch 1/3] add mm argument to pte/pmd/pud/pgd_free schwidefsky
2007-11-12 14:30 ` [patch 2/3] CONFIG_HIGHPTE vs. sub-page page tables schwidefsky
2008-01-02 20:44   ` Christoph Hellwig
2008-01-02 21:24     ` Geert Uytterhoeven
2008-01-02 21:28       ` Benjamin Herrenschmidt
2008-01-03 13:12     ` Andi Kleen
2008-01-03 14:01       ` Boaz Harrosh
2008-02-01 23:15   ` Andrew Morton
2008-02-03  5:37     ` Benjamin Herrenschmidt
2008-02-03  5:53       ` Andrew Morton
2008-02-03  6:46         ` Ingo Molnar
2008-02-04 10:36         ` Martin Schwidefsky
2008-02-04 10:51           ` Andrew Morton
2008-02-04 11:02             ` Russell King
2008-02-04 11:14               ` Andrew Morton
2008-02-05 14:39             ` Martin Schwidefsky
2008-02-05 18:46               ` Andrew Morton
2008-02-06  9:06                 ` Martin Schwidefsky
2008-02-06  9:09                   ` Andrew Morton
2008-02-06  9:15                     ` Ingo Molnar [this message]
2008-02-06 15:50                     ` Martin Schwidefsky
2007-11-12 14:30 ` [patch 3/3] arch_rebalance_pgtables call schwidefsky
2007-11-13 12:33   ` Nick Piggin
2007-11-14  9:26     ` Martin Schwidefsky
2007-11-14 10:06       ` Benjamin Herrenschmidt
2007-11-14 11:49         ` Martin Schwidefsky
2007-11-14 22:07           ` Benjamin Herrenschmidt
2007-11-15 17:13             ` Martin Schwidefsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080206091525.GA26358@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --subject='Re: [patch 2/3] CONFIG_HIGHPTE vs. sub-page page tables.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).