LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] Input updates for 2.6.25-rc0
Date: Wed, 6 Feb 2008 09:19:39 -0500	[thread overview]
Message-ID: <20080206091744.ZZRA012@mailhub.coreip.homeip.net> (raw)
In-Reply-To: <20080206075635.GA6354@uranus.ravnborg.org>

On Wed, Feb 06, 2008 at 08:56:35AM +0100, Sam Ravnborg wrote:
> >  
> > > 
> > > 
> > > 
> > > i8042_platform_init():
> > > 
> > > +#if defined(__i386__) || defined(__x86_64__)
> > > 
> > > use #ifdef CONFIG_X86?
> > > 
> > 
> > I considered it but above was tested and in line with the style of the
> > rest of the file...
> Then please change the rest of the file so it is consistent
> with the usual style to use our CONFIG_ symbols for
> conditionals like the above.
> 

Will do in the next update. The #if defined(__i386__) code predates
CONFIG_X86_32 and was not updated when this symbol became available.

Overall, do you want me to redo the pull or is it still acceptable?

-- 
Dmitry

  reply	other threads:[~2008-02-06 14:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06  6:08 Dmitry Torokhov
2008-02-06  6:32 ` Andrew Morton
2008-02-06  6:49   ` Dmitry Torokhov
2008-02-06  7:56     ` Sam Ravnborg
2008-02-06 14:19       ` Dmitry Torokhov [this message]
2008-02-07 20:05   ` Dmitry Torokhov
2008-02-07 21:00     ` Andrew Morton
2008-02-06  7:00 ` Andrew Morton
2008-02-08 23:25 ` Ingo Molnar
2008-02-08 23:28   ` Stephen Hemminger
2008-02-08 23:37     ` [patch] " Randy Dunlap
2008-02-08 23:49       ` Jesper Juhl
2008-02-08 23:54       ` Andrew Morton
2008-02-09  0:00         ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080206091744.ZZRA012@mailhub.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [git pull] Input updates for 2.6.25-rc0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).