LKML Archive on
help / color / mirror / Atom feed
From: Thadeu Lima de Souza Cascardo <>
Subject: Re: [PATCH] power_supply: Remove capacity_level from list of sysfs attributes
Date: Wed, 6 Feb 2008 08:50:18 -0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Feb 06, 2008 at 12:53:12AM -0800, Andrew Morton wrote:
> On Tue, 5 Feb 2008 14:13:36 -0200 Thadeu Lima de Souza Cascardo <> wrote:
> > ---
> >  drivers/power/power_supply_sysfs.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
> > index d482484..13399d1 100644
> > --- a/drivers/power/power_supply_sysfs.c
> > +++ b/drivers/power/power_supply_sysfs.c
> > @@ -106,7 +106,6 @@ static struct device_attribute power_supply_attrs[] = {
> >  	POWER_SUPPLY_ATTR(energy_now),
> >  	POWER_SUPPLY_ATTR(energy_avg),
> >  	POWER_SUPPLY_ATTR(capacity),
> > -	POWER_SUPPLY_ATTR(capacity_level),
> >  	POWER_SUPPLY_ATTR(temp),
> >  	POWER_SUPPLY_ATTR(temp_ambient),
> >  	POWER_SUPPLY_ATTR(time_to_empty_now),
> What is the reason for making this change?

Sorry. The following commit is the reason for this patch.

It removes CAPACITY_LEVEL from every other code, leaving the array with
sysfs attributes with one more entry than the number of enums in
power_supply.h. This leads to some attributes containing the value of
the attribute right after it. For example, temp_ambient would have the
value of time_to_empty_now. In my case, I had time_to_full_avg have the
value which should be in model_name, when the former was usually empty.

commit 8efe444038a205e79b38b7ad03878824901849a8
Author: Andres Salomon <>
Date:   Wed Dec 12 14:12:56 2007 -0500


    The CAPACITY_LEVEL stuff defines various levels of charge; however, what
    is the difference between them?  What differentiates between HIGH and NORMAL
    LOW and CRITICAL, etc?

    As it appears that these are fairly arbitrary, we end up making such policy
    decisions in the kernel (or in hardware).  This is the sort of decision that
    should be made in userspace, not in the kernel.

    If the hardware does not support _CAPACITY and it cannot be easily calculate
    then perhaps the driver should register a custom CAPACITY_LEVEL attribute;
    however, userspace should not become accustomed to looking for such a thing,
    and we should certainly not encourage drivers to provide CAPACITY_LEVEL

    The following removes support for POWER_SUPPLY_PROP_CAPACITY_LEVEL.  The
    OLPC battery driver is the only driver making use of this, so it's
    removed from there as well.

    Signed-off-by: Andres Salomon <>
    Signed-off-by: David Woodhouse <>

  reply	other threads:[~2008-02-06 10:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 16:13 Thadeu Lima de Souza Cascardo
2008-02-06  8:53 ` Andrew Morton
2008-02-06 10:50   ` Thadeu Lima de Souza Cascardo [this message]
2008-02-06 21:56     ` Andrew Morton
2008-02-07  0:02       ` Anton Vorontsov
2008-02-07  0:36         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \
    --subject='Re: [PATCH] power_supply: Remove capacity_level from list of sysfs attributes' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).