LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* {2.6.22.y} quicklists must keep even off node pages on the quicklists until the TLB flush has been completed.
@ 2008-02-05 21:06 Oliver Pinter
2008-02-06 6:02 ` Dhaval Giani
0 siblings, 1 reply; 6+ messages in thread
From: Oliver Pinter @ 2008-02-05 21:06 UTC (permalink / raw)
To: Linux Kernel, stable, stable-commits
Cc: Christoph Lameter, Dhaval Giani, Andrew Morton, Linus Torvalds,
Greg Kroah-Hartman, chrisw, Willy Tarreau, Adrian Bunk
it is already im queue for 2.6.23,
----8<-----
>From stable-bounces@linux.kernel.org Sat Dec 22 14:04:08 2007
From: Christoph Lameter <clameter@sgi.com>
Date: Sat, 22 Dec 2007 14:03:23 -0800
Subject: quicklists: do not release off node pages early
To: torvalds@linux-foundation.org
Cc: stable@kernel.org, akpm@linux-foundation.org,
dhaval@linux.vnet.ibm.com, clameter@sgi.com
Message-ID: <200712222203.lBMM3Nsk021922@imap1.linux-foundation.org>
From: Christoph Lameter <clameter@sgi.com>
patch ed367fc3a7349b17354c7acef551533337764859 in mainline.
quicklists must keep even off node pages on the quicklists until the TLB
flush has been completed.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Cc: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
include/linux/quicklist.h | 8 --------
1 file changed, 8 deletions(-)
--- a/include/linux/quicklist.h
+++ b/include/linux/quicklist.h
@@ -56,14 +56,6 @@ static inline void __quicklist_free(int
struct page *page)
{
struct quicklist *q;
- int nid = page_to_nid(page);
-
- if (unlikely(nid != numa_node_id())) {
- if (dtor)
- dtor(p);
- __free_page(page);
- return;
- }
q = &get_cpu_var(quicklist)[nr];
*(void **)p = q->page;
---->8------
Tested-by: Oliver Pinter <oliver.pntr@gmail.com> (on i386)
--
Thanks,
Oliver
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: {2.6.22.y} quicklists must keep even off node pages on the quicklists until the TLB flush has been completed.
2008-02-05 21:06 {2.6.22.y} quicklists must keep even off node pages on the quicklists until the TLB flush has been completed Oliver Pinter
@ 2008-02-06 6:02 ` Dhaval Giani
2008-02-06 6:30 ` Oliver Pinter
2008-02-06 18:58 ` Christoph Lameter
0 siblings, 2 replies; 6+ messages in thread
From: Dhaval Giani @ 2008-02-06 6:02 UTC (permalink / raw)
To: Oliver Pinter
Cc: Linux Kernel, stable, stable-commits, Christoph Lameter,
Andrew Morton, Linus Torvalds, Greg Kroah-Hartman, chrisw,
Willy Tarreau, Adrian Bunk
On Tue, Feb 05, 2008 at 10:06:02PM +0100, Oliver Pinter wrote:
> it is already im queue for 2.6.23,
>
> ----8<-----
> >From stable-bounces@linux.kernel.org Sat Dec 22 14:04:08 2007
> From: Christoph Lameter <clameter@sgi.com>
> Date: Sat, 22 Dec 2007 14:03:23 -0800
> Subject: quicklists: do not release off node pages early
> To: torvalds@linux-foundation.org
> Cc: stable@kernel.org, akpm@linux-foundation.org,
> dhaval@linux.vnet.ibm.com, clameter@sgi.com
> Message-ID: <200712222203.lBMM3Nsk021922@imap1.linux-foundation.org>
>
>
> From: Christoph Lameter <clameter@sgi.com>
>
> patch ed367fc3a7349b17354c7acef551533337764859 in mainline.
>
> quicklists must keep even off node pages on the quicklists until the TLB
> flush has been completed.
>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
> Cc: Dhaval Giani <dhaval@linux.vnet.ibm.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> ---
> include/linux/quicklist.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> --- a/include/linux/quicklist.h
> +++ b/include/linux/quicklist.h
> @@ -56,14 +56,6 @@ static inline void __quicklist_free(int
> struct page *page)
> {
> struct quicklist *q;
> - int nid = page_to_nid(page);
> -
> - if (unlikely(nid != numa_node_id())) {
> - if (dtor)
> - dtor(p);
> - __free_page(page);
> - return;
> - }
>
> q = &get_cpu_var(quicklist)[nr];
> *(void **)p = q->page;
>
> ---->8------
> Tested-by: Oliver Pinter <oliver.pntr@gmail.com> (on i386)
>
Christoph,
Is this one also supposed to be backported?
--
regards,
Dhaval
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: {2.6.22.y} quicklists must keep even off node pages on the quicklists until the TLB flush has been completed.
2008-02-06 6:02 ` Dhaval Giani
@ 2008-02-06 6:30 ` Oliver Pinter
2008-02-06 18:58 ` Christoph Lameter
2008-02-06 18:58 ` Christoph Lameter
1 sibling, 1 reply; 6+ messages in thread
From: Oliver Pinter @ 2008-02-06 6:30 UTC (permalink / raw)
To: Dhaval Giani
Cc: Linux Kernel, stable, stable-commits, Christoph Lameter,
Andrew Morton, Linus Torvalds, Greg Kroah-Hartman, chrisw,
Willy Tarreau, Adrian Bunk
I use this, without errors ... but the machine is i386 desktop
On Feb 6, 2008 7:02 AM, Dhaval Giani <dhaval@linux.vnet.ibm.com> wrote:
>
> On Tue, Feb 05, 2008 at 10:06:02PM +0100, Oliver Pinter wrote:
> > it is already im queue for 2.6.23,
> >
> > ----8<-----
> > >From stable-bounces@linux.kernel.org Sat Dec 22 14:04:08 2007
> > From: Christoph Lameter <clameter@sgi.com>
> > Date: Sat, 22 Dec 2007 14:03:23 -0800
> > Subject: quicklists: do not release off node pages early
> > To: torvalds@linux-foundation.org
> > Cc: stable@kernel.org, akpm@linux-foundation.org,
> > dhaval@linux.vnet.ibm.com, clameter@sgi.com
> > Message-ID: <200712222203.lBMM3Nsk021922@imap1.linux-foundation.org>
> >
> >
> > From: Christoph Lameter <clameter@sgi.com>
> >
> > patch ed367fc3a7349b17354c7acef551533337764859 in mainline.
> >
> > quicklists must keep even off node pages on the quicklists until the TLB
> > flush has been completed.
> >
> > Signed-off-by: Christoph Lameter <clameter@sgi.com>
> > Cc: Dhaval Giani <dhaval@linux.vnet.ibm.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> >
> > ---
> > include/linux/quicklist.h | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > --- a/include/linux/quicklist.h
> > +++ b/include/linux/quicklist.h
> > @@ -56,14 +56,6 @@ static inline void __quicklist_free(int
> > struct page *page)
> > {
> > struct quicklist *q;
> > - int nid = page_to_nid(page);
> > -
> > - if (unlikely(nid != numa_node_id())) {
> > - if (dtor)
> > - dtor(p);
> > - __free_page(page);
> > - return;
> > - }
> >
> > q = &get_cpu_var(quicklist)[nr];
> > *(void **)p = q->page;
> >
> > ---->8------
> > Tested-by: Oliver Pinter <oliver.pntr@gmail.com> (on i386)
> >
>
> Christoph,
>
> Is this one also supposed to be backported?
>
> --
> regards,
> Dhaval
>
--
Thanks,
Oliver
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: {2.6.22.y} quicklists must keep even off node pages on the quicklists until the TLB flush has been completed.
2008-02-06 6:02 ` Dhaval Giani
2008-02-06 6:30 ` Oliver Pinter
@ 2008-02-06 18:58 ` Christoph Lameter
2008-02-06 19:06 ` Andrew Morton
1 sibling, 1 reply; 6+ messages in thread
From: Christoph Lameter @ 2008-02-06 18:58 UTC (permalink / raw)
To: Dhaval Giani
Cc: Oliver Pinter, Linux Kernel, stable, stable-commits,
Andrew Morton, Linus Torvalds, Greg Kroah-Hartman, chrisw,
Willy Tarreau, Adrian Bunk
On Wed, 6 Feb 2008, Dhaval Giani wrote:
> Is this one also supposed to be backported?
Yes.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: {2.6.22.y} quicklists must keep even off node pages on the quicklists until the TLB flush has been completed.
2008-02-06 6:30 ` Oliver Pinter
@ 2008-02-06 18:58 ` Christoph Lameter
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Lameter @ 2008-02-06 18:58 UTC (permalink / raw)
To: Oliver Pinter
Cc: Dhaval Giani, Linux Kernel, stable, stable-commits,
Andrew Morton, Linus Torvalds, Greg Kroah-Hartman, chrisw,
Willy Tarreau, Adrian Bunk
On Wed, 6 Feb 2008, Oliver Pinter wrote:
> I use this, without errors ... but the machine is i386 desktop
The fix for off node frees only applies to NUMA systems. !NUMA has no off
node pages.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: {2.6.22.y} quicklists must keep even off node pages on the quicklists until the TLB flush has been completed.
2008-02-06 18:58 ` Christoph Lameter
@ 2008-02-06 19:06 ` Andrew Morton
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2008-02-06 19:06 UTC (permalink / raw)
To: Christoph Lameter
Cc: Dhaval Giani, Oliver Pinter, Linux Kernel, stable,
stable-commits, Linus Torvalds, Greg Kroah-Hartman, chrisw,
Willy Tarreau, Adrian Bunk
On Wed, 6 Feb 2008 10:58:13 -0800 (PST) Christoph Lameter <clameter@sgi.com> wrote:
> On Wed, 6 Feb 2008, Dhaval Giani wrote:
>
> > Is this one also supposed to be backported?
>
> Yes.
So mainline's ed367fc3a7349b17354c7acef551533337764859 needs to be backported
to 2.6.23.x.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-02-06 19:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-05 21:06 {2.6.22.y} quicklists must keep even off node pages on the quicklists until the TLB flush has been completed Oliver Pinter
2008-02-06 6:02 ` Dhaval Giani
2008-02-06 6:30 ` Oliver Pinter
2008-02-06 18:58 ` Christoph Lameter
2008-02-06 18:58 ` Christoph Lameter
2008-02-06 19:06 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).