LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Gianluca Alberici <gianluca@abinetworks.biz>
Cc: chuck.lever@oracle.com, linux-nfs@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: NFS EINVAL on open(... | O_TRUNC) on 2.6.23.9
Date: Wed, 6 Feb 2008 14:16:36 -0800	[thread overview]
Message-ID: <20080206141636.1001b1c5.akpm@linux-foundation.org> (raw)
In-Reply-To: <47AA2CB6.9070908@abinetworks.biz>

On Wed, 06 Feb 2008 22:55:02 +0100
Gianluca Alberici <gianluca@abinetworks.biz> wrote:

> I finally got it. Problem and solution have been found from 6 month but 
> nobody cared...up to now those servers have not been mantained, this 
> problem is not discussed anywhere else than the following link.
> The bug (userspace server side i would say at this point) is well 
> described from the author of an nfs-user-server patch which has not been 
> managed yet. The magic hint to find it on google was 'nfs server 
> utimensat' :-)
> 
> http://marc.info/?l=linux-nfs&m=118724649406144&w=2

This is pretty significant.  We have on several occasions in recent years
tightened up the argument checking on long-standing system calls and it's
always a concern that this will break previously-working applications.

And now it has happened.

If we put buggy code into the kernel then we're largely stuck with it: we
need to be back-compatible with our bugs so we don't break things like
this.

> I have already prepared a working patch for cfsd based upon the one ive 
> listed. The nfs patch is of course waiting for commit since august, 
> 2007. Ill submit it to debian cfsd mantainers, hoping to have more 
> chance than my predecessor.
> It doesnt seem to me that there was any kernel related issue.
> 
> Thanks a lot again, sorry for the lots of noise i have done. I will try 
> to be more appropriate next time.

That wasn't noise - it was quite valuable.  Thanks for all the work you did
on this.


Given that our broken-by-unbreaking code has been out there in several
releases there isn't really any point in rebreaking it to fix this - the
offending applications need to be repaired so they'll work on 2.6.22 and
2.6.23 anyway.


      reply	other threads:[~2008-02-06 22:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-22 10:52 Gianluca Alberici
2007-12-23  7:17 ` Scott
2007-12-23 11:35   ` Gianluca Alberici
2007-12-25 22:04     ` Andrew Morton
2007-12-26 11:14       ` Gianluca Alberici
2007-12-26 14:24       ` Chuck Lever
2008-01-19 11:29         ` Gianluca Alberici
2008-01-19 12:35         ` Gianluca Alberici
     [not found]           ` <5FD6714F-EF9A-4F07-B2B6-D6F6CC911936@oracle.com>
     [not found]             ` <479C744A.6020207@abinetworks.biz>
     [not found]               ` <12964A18-350B-443F-B15A-D78B3723C89A@oracle.com>
     [not found]                 ` <479F2463.2040704@abinetworks.biz>
     [not found]                   ` <4AAA3DAF-898C-4ED5-BD07-4FD2B5CEEF16@oracle.com>
     [not found]                     ` <Pine.LNX.4.64.0801291851110.4820@maggie.lkpg.cendio.se>
     [not found]                       ` <7EE4B02B-3359-41C0-BFED-0947DF9F5F5A@oracle.com>
     [not found]                         ` <479F8377.6090704@abinetworks.biz>
     [not found]                           ` <1201638661.7969.7.camel@heimdal.trondhjem.org>
     [not found]                             ` <F7BFE847-A3C3-44E5-A238-5C69ED3EE1C4@oracle.com>
     [not found]                               ` <47A0704D.7080808@abinetworks.biz>
     [not found]                                 ` <AB6DF303-5C5B-453C-9992-DAF826FF02CE@oracle.com>
2008-02-06 18:25                                   ` Gianluca Alberici
2008-02-06 19:47                                     ` Chuck Lever
2008-02-06 21:55                                       ` Gianluca Alberici
2008-02-06 22:16                                         ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080206141636.1001b1c5.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=chuck.lever@oracle.com \
    --cc=gianluca@abinetworks.biz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --subject='Re: NFS EINVAL on open(... | O_TRUNC) on 2.6.23.9' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).