LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "J. K. Cliburn" <jacliburn@bellsouth.net>
Cc: Zan Lynx <zlynx@acm.org>, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: MM kernels 2.6.24-rc*-mm*, 2.6.24-mm1: gnome-terminal stuck in tty_poll
Date: Wed, 6 Feb 2008 18:23:29 -0800	[thread overview]
Message-ID: <20080206182329.b0956b4a.akpm@linux-foundation.org> (raw)
In-Reply-To: <47AA68AA.3090009@bellsouth.net>

On Wed, 06 Feb 2008 20:10:50 -0600 "J. K. Cliburn" <jacliburn@bellsouth.net> wrote:

> Zan Lynx wrote:
> 
> > gnome-terminal gets stuck.
> 
> I began seeing this very thing around 2.6.24 time.  (Fedora 8, vanilla 
> kernel.)  I could usually cause the gnome terminal to hang if I rapidly 
> resized the window while executing make check-headers.
> 
> Over a couple of days I bisected it down to this commit:
> 
> Commit:     37bb6cb4097e29ffee970065b74499cbf10603a3
> Parent:     d3d74453c34f8fd87674a8cf5b8a327c68f22e99
> Author:     Peter Zijlstra <a.p.zijlstra@chello.nl>
> AuthorDate: Fri Jan 25 21:08:32 2008 +0100
> Committer:  Ingo Molnar <mingo@elte.hu>
> CommitDate: Fri Jan 25 21:08:32 2008 +0100
> 
>      hrtimer: unlock hrtimer_wakeup
> 
>      hrtimer_wakeup creates a
> 
>        base->lock
>          rq->lock
> 
>      lock dependancy. Avoid this by switching to 
> HRTIMER_CB_IRQSAFE_NO_SOFTIRQ
>      which doesn't hold base->lock.
> 
>      This fully untangles hrtimer locks from the scheduler locks, and allows
>      hrtimer usage in the scheduler proper.
> 
>      Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
>      Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
>   kernel/hrtimer.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
> 
> 
> Reverting the commit seemed to fix the problem for me.
> 
> Then I went away on a business trip Monday morning and returned Tuesday 
> night to a dead computer (won't POST), so I can't do any further 
> troubleshooting until I get it fixed.

Useful, thanks.

> Try reverting that patch and see if your gnome-terminal freezes go away.

Here is a convenient patch against current mainline:


--- a/kernel/hrtimer.c~revert-1
+++ a/kernel/hrtimer.c
@@ -1292,7 +1292,7 @@ void hrtimer_init_sleeper(struct hrtimer
 	sl->timer.function = hrtimer_wakeup;
 	sl->task = task;
 #ifdef CONFIG_HIGH_RES_TIMERS
-	sl->timer.cb_mode = HRTIMER_CB_IRQSAFE_NO_SOFTIRQ;
+	sl->timer.cb_mode = HRTIMER_CB_IRQSAFE_NO_RESTART;
 #endif
 }
 
@@ -1303,8 +1303,6 @@ static int __sched do_nanosleep(struct h
 	do {
 		set_current_state(TASK_INTERRUPTIBLE);
 		hrtimer_start(&t->timer, t->timer.expires, mode);
-		if (!hrtimer_active(&t->timer))
-			t->task = NULL;
 
 		if (likely(t->task))
 			schedule();
_


  reply	other threads:[~2008-02-07  2:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 19:38 Zan Lynx
2008-02-06 19:44 ` Alan Cox
2008-02-06 20:16   ` Zan Lynx
2008-02-07  2:10 ` J. K. Cliburn
2008-02-07  2:23   ` Andrew Morton [this message]
2008-02-07 19:49     ` Peter Zijlstra
2008-02-07 20:24       ` Peter Zijlstra
2008-02-08  1:26         ` Jay Cliburn
2008-02-08  9:28           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080206182329.b0956b4a.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=jacliburn@bellsouth.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zlynx@acm.org \
    --subject='Re: MM kernels 2.6.24-rc*-mm*, 2.6.24-mm1: gnome-terminal stuck in tty_poll' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).