LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Roland Dreier <rdreier@cisco.com>,
	len.brown@intel.com, ibm-acpi-devel@lists.sourceforge.net,
	linux-acpi@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
	stable@kernel.org
Subject: Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)
Date: Wed, 6 Feb 2008 15:07:02 -0800	[thread overview]
Message-ID: <20080206230702.GA12395@kroah.com> (raw)
In-Reply-To: <47A81FAE.2090709@tiscali.nl>

On Tue, Feb 05, 2008 at 09:34:54AM +0100, Roel Kluin wrote:
> Henrique de Moraes Holschuh wrote:
> > On Tue, 05 Feb 2008, Roel Kluin wrote:
> >> Roland Dreier wrote:
> >>>  >                 /* safety net should the EC not support AUTO
> >>>  >                  * or FULLSPEED mode bits and just ignore them */
> >>>  >                 if (level & TP_EC_FAN_FULLSPEED)
> >>>  >                         level |= 7;     /* safety min speed 7 */
> >>>  >                 else if (level & TP_EC_FAN_FULLSPEED)
> >>>  >                         level |= 4;     /* safety min speed 4 */
> >>>  > 
> >>>  > Note the duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'. should
> >>>  > this be replaced by
> >>>
> >>> Actually I suspect one of the two tests should be against TP_EC_FAN_AUTO
> >>> (based on the comment).
> >> Thanks Roland, for your info
> >>
> >> based on the comments in commit eaa7571b2d1a08873e4bdd8e6db3431df61cd9ad,
> >> I think this should be modified like below:
> >>
> >> ACPI: thinkpad-acpi: add a safety net for TPEC fan control mode
> >> The Linux ThinkPad community is not positive that all ThinkPads that do
> >> HFSP EC fan control do implement full-speed and auto modes, some of the
> >> earlier ones supporting HFSP might not.
> >>
> >> If the EC ignores the AUTO or FULL-SPEED bits, it will pay attention to the
> >> lower three bits that set the fan level. And as thinkpad-acpi was leaving
> >> these set to zero, it would stop(!) the fan, which is Not A Good Thing.
> >> So, as a safety net, we now make sure to also set the fan level part of the
> >> HFSP register to speed 7 for full-speed, and a minimum of speed 4 for auto
> >> mode.
> >> --
> >> second TP_EC_FAN_FULLSPEED should be P_EC_FAN_AUTO
> >>
> >>
> >> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> >> ---
> >> diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c
> >> index cf56647..3c323fe 100644
> >> --- a/drivers/misc/thinkpad_acpi.c
> >> +++ b/drivers/misc/thinkpad_acpi.c
> >> @@ -4138,7 +4138,7 @@ static int fan_set_level(int level)
> >>  		 * or FULLSPEED mode bits and just ignore them */
> >>  		if (level & TP_EC_FAN_FULLSPEED)
> >>  			level |= 7;	/* safety min speed 7 */
> >> -		else if (level & TP_EC_FAN_FULLSPEED)
> >> +		else if (level & TP_EC_FAN_AUTO)
> >>  			level |= 4;	/* safety min speed 4 */
> >>  
> >>  		if (!acpi_ec_write(fan_status_offset, level))
> > 
> > ACK.  This needs to be sent to stable as well.  I think both 2.6.22 and
> > 2.6.23 need this patch.
> > 
> 
> CC stable@kernel.org

Please send us a real copy of the patch, when it goes into Linus's tree,
so we know what to apply, and that it is safe to do so.

thanks,

greg k-h

  reply	other threads:[~2008-02-06 23:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-04 22:07 [drivers/misc/thinkpad_acpi.c] " Roel Kluin
2008-02-04 22:13 ` Roland Dreier
2008-02-04 23:24   ` [PATCH][drivers/misc/thinkpad_acpi.c] " Roel Kluin
2008-02-05  5:05     ` Henrique de Moraes Holschuh
2008-02-05  8:34       ` Roel Kluin
2008-02-06 23:07         ` Greg KH [this message]
2008-02-06 23:48           ` Roel Kluin
2008-02-07  1:18             ` Henrique de Moraes Holschuh
2008-02-07  7:28               ` [stable] " Greg KH
2008-02-07  5:55             ` Greg KH
2008-02-07  6:17     ` Len Brown
  -- strict thread matches above, loose matches on Subject: below --
2008-02-04 21:59 [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test 'if (level & TP_EC_FAN_FULLSPEED)' Roel kluin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080206230702.GA12395@kroah.com \
    --to=greg@kroah.com \
    --cc=12o3l@tiscali.nl \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdreier@cisco.com \
    --cc=stable@kernel.org \
    --subject='Re: [PATCH][drivers/misc/thinkpad_acpi.c] duplicate test if (level & TP_EC_FAN_FULLSPEED)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).