From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764960AbYBGADb (ORCPT ); Wed, 6 Feb 2008 19:03:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764059AbYBFXzH (ORCPT ); Wed, 6 Feb 2008 18:55:07 -0500 Received: from ns1.suse.de ([195.135.220.2]:45371 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764027AbYBFXzE (ORCPT ); Wed, 6 Feb 2008 18:55:04 -0500 Date: Wed, 6 Feb 2008 15:51:53 -0800 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, bunk@kernel.org, maximilian attems , "David S. Miller" Subject: [patch 19/73] IRDA: irda_create() nuke user triggable printk Message-ID: <20080206235153.GT13121@suse.de> References: <20080206234302.769849277@mini.kroah.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="irda-irda_create-nuke-user-triggable-printk.patch" In-Reply-To: <20080206235015.GA13121@suse.de> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.23-stable review patch. If anyone has any objections, please let us know. ------------------ From: maximilian attems [IRDA]: irda_create() nuke user triggable printk [ Upstream commit: 9e8d6f8959c356d8294d45f11231331c3e1bcae6 ] easy to trigger as user with sfuzz. irda_create() is quiet on unknown sock->type, match this behaviour for SOCK_DGRAM unknown protocol Signed-off-by: maximilian attems Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/irda/af_irda.c | 2 -- 1 file changed, 2 deletions(-) --- a/net/irda/af_irda.c +++ b/net/irda/af_irda.c @@ -1115,8 +1115,6 @@ static int irda_create(struct socket *so self->max_sdu_size_rx = TTP_SAR_UNBOUND; break; default: - IRDA_ERROR("%s: protocol not supported!\n", - __FUNCTION__); return -ESOCKTNOSUPPORT; } break; --