LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, kay.sievers@vrfy.org
Subject: Re: partition sysfs OOPS in current GIT
Date: Wed, 6 Feb 2008 21:47:38 -0800	[thread overview]
Message-ID: <20080207054738.GB20902@suse.de> (raw)
In-Reply-To: <20080206.200618.11213859.davem@davemloft.net>

On Wed, Feb 06, 2008 at 08:06:18PM -0800, David Miller wrote:
> 
> Greg, I'm pretty sure I know what's happening.
> 
> For whatever reason we're invoking dev_attr_show() on attribute_group
> objects.

Ugh, that makes sense.

> The reason it probably only crashes on sparc64 is because perhaps at
> that dev_attr->show offset on x86 there are zero bytes there instead
> of a pointer, so the NULL check here in dev_attr_show() masks the bug.
> 
> The problem with all of this "container_of() this", "container_of()
> that" is that we lose real type checking.  So unless we add magic
> cookies to verify or other hacks, functions never really know if the
> container they are being passed really is a subset object of the type
> they expect.

We are supposed to be careful about this, but bad things are known to
happen :)

> Can you read the code instead of asking more information from me to
> try and figure out why the attribute showing paths might be
> misconfigured for these block device objects after the changeset in
> question?  I can do this, but you're more likely to find the problem
> quickly than I am.

Yes, I'll look into it tonight if I get this -stable push out in time,
or if not, first thing in the morning.

> I redid the bisect to make sure it absolutely was that specific
> changeset, and it is.

Thanks for doing that, I'll let you know when I have a patch to test.

greg k-h

  reply	other threads:[~2008-02-07  5:43 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 23:26 David Miller
2008-02-06 23:31 ` Greg KH
2008-02-06 23:37   ` David Miller
2008-02-06 23:48     ` David Miller
2008-02-06 23:59     ` Greg KH
2008-02-07  0:02       ` David Miller
2008-02-07  0:09         ` Greg KH
2008-02-07  0:29           ` David Miller
2008-02-07  4:06           ` David Miller
2008-02-07  5:47             ` Greg KH [this message]
2008-02-07  6:05               ` David Miller
2008-02-07  6:38                 ` Greg KH
2008-02-07  6:38                   ` David Miller
2008-02-07  6:42                 ` Greg KH
2008-02-07  6:39                   ` David Miller
2008-02-07  6:58                     ` Greg KH
2008-02-07  7:00                     ` Greg KH
2008-02-07  7:11                       ` David Miller
2008-02-07  7:18                         ` Greg KH
2008-02-07  7:33                           ` David Miller
2008-02-07  7:43                             ` Greg KH
2008-02-07  7:20                         ` Greg KH
2008-02-07  7:24                           ` David Miller
2008-02-07  7:42                             ` Greg KH
2008-02-07  6:44                 ` Greg KH
2008-02-07  6:42                   ` David Miller
2008-02-06 23:57   ` Andrew Morton
2008-02-07  0:07     ` Greg KH
2008-02-06 23:42 ` Oops figures Jan Engelhardt
2008-02-06 23:47   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080207054738.GB20902@suse.de \
    --to=gregkh@suse.de \
    --cc=davem@davemloft.net \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: partition sysfs OOPS in current GIT' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).