LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: clean up find_e820_area
Date: Thu, 7 Feb 2008 09:12:39 +0100	[thread overview]
Message-ID: <20080207081239.GC28631@elte.hu> (raw)
In-Reply-To: <200802062023.30427.yinghai.lu@sun.com>


* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:

> [PATCH] x86_64: clean up find_e820_area
> 
> change size to unsigned long, becase caller and user all used unsigned 
> long. also make bad_addr take align.

thanks, applied.

[ tiny nitpicking detail:

 > -static inline int bad_addr(unsigned long *addrp, unsigned long size)
 > +static inline int bad_addr(unsigned long *addrp, unsigned long size, unsigned long align)

 please run scripts/checkpatch.pl over your patches, that would have 
 caught the above overlong line. ]

> @@ -105,7 +105,7 @@ again:
>  	for (i = 0; i < MAX_EARLY_RES && early_res[i].end; i++) {
>  		struct early_res *r = &early_res[i];
>  		if (last >= r->start && addr < r->end) {
> -			*addrp = addr = r->end;
> +			*addrp = addr = round_up(r->end, align);

nice! This makes the reservation intent and effect much clearer.

	Ingo

  reply	other threads:[~2008-02-07  8:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 20:46 my config doesnt compile in your tree Yinghai Lu
2008-02-06 21:53 ` Ingo Molnar
2008-02-06 23:01   ` Yinghai Lu
     [not found]     ` <20080206231226.GA6417@elte.hu>
2008-02-07  4:22       ` [PATCH] x86_64: fix page table size Yinghai Lu
2008-02-07  4:23         ` [PATCH] x86_64: clean up find_e820_area Yinghai Lu
2008-02-07  8:12           ` Ingo Molnar [this message]
2008-02-07  7:23         ` [PATCH] x86_64: fix page table size Andi Kleen
2008-02-07 11:54           ` Ingo Molnar
2008-02-07 17:28             ` Andi Kleen
2008-02-07  8:09         ` Ingo Molnar
2008-02-07  8:36           ` Yinghai Lu
2008-02-07  8:49             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080207081239.GC28631@elte.hu \
    --to=mingo@elte.hu \
    --cc=Yinghai.Lu@Sun.COM \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] x86_64: clean up find_e820_area' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).