LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
To: sfr@canb.auug.org.au
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
	linux-kernel@vger.kernel.org, tomof@acm.org,
	fujita.tomonori@lab.ntt.co.jp
Subject: Re: Ordering of commits and breaking bisecting
Date: Thu, 07 Feb 2008 08:22:27 +0900	[thread overview]
Message-ID: <20080207082227O.fujita.tomonori@lab.ntt.co.jp> (raw)
In-Reply-To: <20080206093817.60091256.sfr@canb.auug.org.au>

On Wed, 6 Feb 2008 09:38:17 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> Can we be a bit more careful with the ordering of commits, please?
> Commit d22a6966b8029913fac37d078ab2403898d94c63 (iommu sg merging: add
> accessors for segment_boundary_mask in device_dma_parameters())
> introduces the dma_get_seg_boundary accessor which is used in the
> *preceding* commits fb3475e9b6bfa666107512fbd6006c26014f04b8 (for
> powerpc), and 1b39b077789955c8389488d53d075518fdcd582e and
> fde9a1094ddf2892188a8a0eccda527de47cba8e (for x86).
> 
> Thus we have another set of commits that will break bisection.  This one
> was easily avoidable.
> 
> A little more care is needed.

Sorry about it.

I submitted the patches in the proper order but the order seemed to be
reversed in the -mm.

http://www.mail-archive.com/linux-scsi@vger.kernel.org/msg11919.html

I could have noticed the issue since it has been in the -mm for a long
time, sorry.

      reply	other threads:[~2008-02-06 23:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 22:38 Stephen Rothwell
2008-02-06 23:22 ` FUJITA Tomonori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080207082227O.fujita.tomonori@lab.ntt.co.jp \
    --to=fujita.tomonori@lab.ntt.co.jp \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tomof@acm.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: Ordering of commits and breaking bisecting' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).