LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Ordering of commits and breaking bisecting
@ 2008-02-05 22:38 Stephen Rothwell
  2008-02-06 23:22 ` FUJITA Tomonori
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2008-02-05 22:38 UTC (permalink / raw)
  To: Andrew Morton, Linus; +Cc: LKML, FUJITA Tomonori

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

Hi all,

Can we be a bit more careful with the ordering of commits, please?
Commit d22a6966b8029913fac37d078ab2403898d94c63 (iommu sg merging: add
accessors for segment_boundary_mask in device_dma_parameters())
introduces the dma_get_seg_boundary accessor which is used in the
*preceding* commits fb3475e9b6bfa666107512fbd6006c26014f04b8 (for
powerpc), and 1b39b077789955c8389488d53d075518fdcd582e and
fde9a1094ddf2892188a8a0eccda527de47cba8e (for x86).

Thus we have another set of commits that will break bisection.  This one
was easily avoidable.

A little more care is needed.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Ordering of commits and breaking bisecting
  2008-02-05 22:38 Ordering of commits and breaking bisecting Stephen Rothwell
@ 2008-02-06 23:22 ` FUJITA Tomonori
  0 siblings, 0 replies; 2+ messages in thread
From: FUJITA Tomonori @ 2008-02-06 23:22 UTC (permalink / raw)
  To: sfr; +Cc: akpm, torvalds, linux-kernel, tomof, fujita.tomonori

On Wed, 6 Feb 2008 09:38:17 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> Can we be a bit more careful with the ordering of commits, please?
> Commit d22a6966b8029913fac37d078ab2403898d94c63 (iommu sg merging: add
> accessors for segment_boundary_mask in device_dma_parameters())
> introduces the dma_get_seg_boundary accessor which is used in the
> *preceding* commits fb3475e9b6bfa666107512fbd6006c26014f04b8 (for
> powerpc), and 1b39b077789955c8389488d53d075518fdcd582e and
> fde9a1094ddf2892188a8a0eccda527de47cba8e (for x86).
> 
> Thus we have another set of commits that will break bisection.  This one
> was easily avoidable.
> 
> A little more care is needed.

Sorry about it.

I submitted the patches in the proper order but the order seemed to be
reversed in the -mm.

http://www.mail-archive.com/linux-scsi@vger.kernel.org/msg11919.html

I could have noticed the issue since it has been in the -mm for a long
time, sorry.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-06 23:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-05 22:38 Ordering of commits and breaking bisecting Stephen Rothwell
2008-02-06 23:22 ` FUJITA Tomonori

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).