LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Jean Delvare <khali@linux-fr.org>,
	lkml <linux-kernel@vger.kernel.org>,
	akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -mm] apanel: fix kconfig dependencies
Date: Thu, 7 Feb 2008 11:12:20 -0800	[thread overview]
Message-ID: <20080207111220.4239d5d4@extreme> (raw)
In-Reply-To: <20080207110412.792db623.randy.dunlap@oracle.com>

On Thu, 7 Feb 2008 11:04:12 -0800
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> On Thu, 7 Feb 2008 17:42:51 +0100 Jean Delvare wrote:
> 
> > Hi Randy,
> > 
> > On Wed, 6 Feb 2008 16:27:54 -0800, Randy Dunlap wrote:
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > 
> > > Add I2C to config since the driver makes several i2c*() calls.
> > 
> > Correct.
> > 
> > > 
> > > Add PCI to config because the config selects I2C_I801, which depends
> > > on PCI, but currently config* does not follow dependency chains,
> > > so randconfig can enable INPUT_APANEL even when PCI is not enabled,
> > > which leads to these warnings:
> > > linux-2.6.24-mm1/drivers/i2c/busses/i2c-i801.c:641: error: implicit declaration of function 'pci_request_region'
> > > /linux-2.6.24-mm1/drivers/i2c/busses/i2c-i801.c:681: error: implicit declaration of function 'pci_release_region'
> > 
> > I'd rather drop the "select I2C_I801" if the config system can't handle
> > it properly. It's not strictly needed (not a build-time dependency), an
> > addition to the help text would work as well. Adding dependencies to
> > make our selections happy is a bit confusing and likely to cause
> > trouble in the future (as dependencies can change...)
> 
> OK.  What did you have in mind for the help text.  I changed it
> a small bit.
> 
> I also added "depends on LEDS_CLASS" since defconfig didn't have that
> set, but the build failed with wanting symbols that it provides.
> 
> Updated patch:
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Add I2C to config since the driver makes several i2c*() calls.
> 
> Add to help text that the Intel I2C ICH (i801) driver is also needed
> for this kernel.
> 
> Add LEDS_CLASS to config since the driver makes les_classdev_*() calls:
> ERROR: "led_classdev_register" [drivers/input/misc/apanel.ko] undefined!
> ERROR: "__led_classdev_unregister" [drivers/input/misc/apanel.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>


On a related note, Ubuntu puts the i2c_i801 module in /etc/modprobe.d/blacklist.
To get the apanel to work, this must be removed, but that is a distro bug.

-- 
Stephen Hemminger <stephen.hemminger@vyatta.com>

  reply	other threads:[~2008-02-07 19:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07  0:27 Randy Dunlap
2008-02-07 16:42 ` Jean Delvare
2008-02-07 19:04   ` Randy Dunlap
2008-02-07 19:12     ` Stephen Hemminger [this message]
2008-02-07 21:46     ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080207111220.4239d5d4@extreme \
    --to=shemminger@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --subject='Re: [PATCH -mm] apanel: fix kconfig dependencies' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).