LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Daniel Phillips <phillips@phunq.net>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Phil Oester <kernel@linuxace.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Jason Wessel <jason.wessel@windriver.com>
Subject: Re: [git pull] x86 arch updates for v2.6.25
Date: Thu, 7 Feb 2008 12:00:18 -0800 [thread overview]
Message-ID: <200802071200.19533.phillips@phunq.net> (raw)
In-Reply-To: <47A9A356.8080400@siemens.com>
On Wednesday 06 February 2008 04:08, Jan Kiszka wrote:
> While too many people consider a debugger as _the_ tool for kernel
> development, which it clearly isn't, it remains a fairly useful
> feature, and I don't see any regression, technically or
> organizationally, it may introduce to Linux. IMHO, it would be a pity
> if kgdb have to remain out off tree and may potentially fall back at
> quality levels that many of us had fought with in the past.
I do pretty much all my debugging with printk, not just because it is a
pain to go find a working kgdb patch, but also because tools like uml
make printk style debugging really fast. That said, I often find my
development time sinking away into tedious activity like putting in a
printk after each line of code, just to find out where some bad thing
started going bad. At that point a source level debugger would save me
a bunch of time and I would not have to remove the printks afterwards.
However, if the time required to patch the kernel with kgdb is more than
the time spent putting in prinks then I will just grit my teeth and put
in the printks. Never mind that I will end up going through the printk
insertion process many times, while only needing to apply the kgdb
patch once. Ahem, that is once per kernel version, and I change kernel
versions like I change socks (that means "often" for the wags among
you.)
One thing I like to do with a source level debugger besides debugging is
take a walk once through some new algorithm I have implemented. Not
because I think there is a bug, but more for the same reason that I
like to do a side by side walkthrough of new code with another
developer before ever running it. This just provides a different
perspective, so that perhaps some little blemishes, inefficiencies and
redundancies will show themselves, and the code quality usually
improves because of it.
Not that this is the only way I review my own code, it is just another
way. More ways of reviewing code are better. In this sense, the
debugger is like a mechanical friend who always has time available to
join in a side by side code review.
Regards,
Daniel
next prev parent reply other threads:[~2008-02-07 20:01 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 1:15 Ingo Molnar
2008-01-31 0:33 ` x86 arch updates also broke s390 Adrian Bunk
2008-01-31 9:34 ` Martin Schwidefsky
2008-01-31 10:24 ` Ingo Molnar
2008-01-31 12:37 ` Nick Piggin
2008-02-01 9:48 ` Ingo Molnar
2008-02-01 9:52 ` Ingo Molnar
2008-02-01 9:54 ` Martin Schwidefsky
2008-02-01 10:02 ` Ingo Molnar
2008-01-31 15:57 ` [git pull] x86 arch updates for v2.6.25 Adrian Bunk
2008-01-31 16:00 ` Ingo Molnar
2008-01-31 16:04 ` Ingo Molnar
2008-01-31 16:12 ` Adrian Bunk
2008-01-31 16:15 ` Ingo Molnar
2008-01-31 16:21 ` WANG Cong
2008-01-31 16:24 ` Adrian Bunk
2008-01-31 16:46 ` Ingo Molnar
2008-01-31 16:52 ` Jeremy Fitzhardinge
2008-01-31 16:29 ` sparc compile error caused by x86 arch updates Adrian Bunk
2008-01-31 16:50 ` Jeremy Fitzhardinge
2008-01-31 17:43 ` Ingo Molnar
2008-01-31 17:55 ` Jeremy Fitzhardinge
2008-01-31 18:21 ` Adrian Bunk
2008-01-31 18:38 ` Ingo Molnar
2008-02-05 2:36 ` [git pull] x86 arch updates for v2.6.25 Maxim Levitsky
2008-02-05 3:27 ` Linus Torvalds
2008-02-05 4:11 ` Phil Oester
2008-02-05 4:54 ` Andrew Morton
2008-02-06 12:08 ` Jan Kiszka
2008-02-07 20:00 ` Daniel Phillips [this message]
2008-02-08 4:48 ` Christoph Hellwig
2008-02-08 9:51 ` Jan Kiszka
2008-02-05 17:45 ` John Stoffel
2008-02-05 17:52 ` H. Peter Anvin
2008-02-08 18:24 ` Bernhard Kaindl
2008-02-08 19:38 ` remote DMA via FireWire (was Re: [git pull] x86 arch updates for v2.6.25) Stefan Richter
2008-02-07 19:20 ` [git pull] x86 arch updates for v2.6.25 Daniel Phillips
2008-02-08 17:00 ` Andi Kleen
2008-02-08 17:48 ` Jan Kiszka
2008-02-08 18:57 ` Andi Kleen
2008-02-08 21:28 ` [RFC][PATCH] KGDB: remove kgdb-own fault handling (was: Re: [git pull] x86 arch updates for v2.6.25) Jan Kiszka
2008-02-08 21:58 ` Linus Torvalds
2008-02-08 22:16 ` [RFC][PATCH] KGDB: remove kgdb-own fault handling Jason Wessel
2008-02-09 14:11 ` [git pull] x86 arch updates for v2.6.25 Amit Shah
2008-02-10 12:30 ` Jiri Kosina
2008-02-12 7:16 ` Amit Shah
2008-02-13 8:56 ` Ingo Molnar
2008-02-13 10:19 ` Amit Shah
2008-02-06 2:28 David Cullen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802071200.19533.phillips@phunq.net \
--to=phillips@phunq.net \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=jason.wessel@windriver.com \
--cc=kernel@linuxace.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--subject='Re: [git pull] x86 arch updates for v2.6.25' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).