LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [git pull] Input updates for 2.6.25-rc0
Date: Thu, 7 Feb 2008 13:00:40 -0800	[thread overview]
Message-ID: <20080207130040.7a03324e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080207150305.ZZRA012@mailhub.coreip.homeip.net>

On Thu, 7 Feb 2008 15:05:57 -0500
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:

> On Tue, Feb 05, 2008 at 10:32:42PM -0800, Andrew Morton wrote:
> > 
> > Looks OK.  Minorish things from a quick scan:
> > 
> 
> *ping*
> 
> Linus,
> 
> Do you want me to redo the pull or is it still acceptable as is?
> I am hesitant touching the tree after sending a pull request...
> 

That's probably me being a pain in the ass and actually looking at the pull
requests.  Sorry, I really should look at these things as they go into
people's trees, not as they attempt to come out of them.  I'll do better.

Although that's not an option with some of the stealth merges we're seeing
lately..

I'd assume that by now you can apply whatever touchups are needed then
resend the pull request.



btw:

drivers/input/touchscreen/ads7846.c: fix uninitialized var warning

From: Andrew Morton <akpm@linux-foundation.org>

drivers/input/touchscreen/ads7846.c: In function 'ads7846_read12_ser':
drivers/input/touchscreen/ads7846.c:216: warning: 'sample' may be used uninitialized in this function

Cc: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/input/touchscreen/ads7846.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/input/touchscreen/ads7846.c~drivers-input-touchscreen-ads7846c-fix-uninitialized-var-warning drivers/input/touchscreen/ads7846.c
--- a/drivers/input/touchscreen/ads7846.c~drivers-input-touchscreen-ads7846c-fix-uninitialized-var-warning
+++ a/drivers/input/touchscreen/ads7846.c
@@ -213,7 +213,7 @@ static int ads7846_read12_ser(struct dev
 	struct ads7846		*ts = dev_get_drvdata(dev);
 	struct ser_req		*req = kzalloc(sizeof *req, GFP_KERNEL);
 	int			status;
-	int			sample;
+	int			uninitialized_var(sample);
 	int			use_internal;
 
 	if (!req)
_


  reply	other threads:[~2008-02-07 21:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06  6:08 Dmitry Torokhov
2008-02-06  6:32 ` Andrew Morton
2008-02-06  6:49   ` Dmitry Torokhov
2008-02-06  7:56     ` Sam Ravnborg
2008-02-06 14:19       ` Dmitry Torokhov
2008-02-07 20:05   ` Dmitry Torokhov
2008-02-07 21:00     ` Andrew Morton [this message]
2008-02-06  7:00 ` Andrew Morton
2008-02-08 23:25 ` Ingo Molnar
2008-02-08 23:28   ` Stephen Hemminger
2008-02-08 23:37     ` [patch] " Randy Dunlap
2008-02-08 23:49       ` Jesper Juhl
2008-02-08 23:54       ` Andrew Morton
2008-02-09  0:00         ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080207130040.7a03324e.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [git pull] Input updates for 2.6.25-rc0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).