LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 01/18] MMC: OMAP: Include missing from previous merging
@ 2008-01-28 19:07 Carlos Aguiar
  2008-02-07 17:21 ` Pierre Ossman
  0 siblings, 1 reply; 3+ messages in thread
From: Carlos Aguiar @ 2008-01-28 19:07 UTC (permalink / raw)
  To: Pierre Ossman; +Cc: Tony Lindgren, linux-kernel

From: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>

This patch adds an include missing from previous merging
mainline tree into linux-omap tree.

Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 drivers/mmc/host/omap.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index c9dfeb1..9374163 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -21,6 +21,7 @@
 #include <linux/delay.h>
 #include <linux/spinlock.h>
 #include <linux/timer.h>
+#include <linux/mmc/mmc.h>
 #include <linux/mmc/host.h>
 #include <linux/mmc/card.h>
 #include <linux/clk.h>
-- 1.5.3.GIT


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 01/18] MMC: OMAP: Include missing from previous merging
  2008-01-28 19:07 [PATCH 01/18] MMC: OMAP: Include missing from previous merging Carlos Aguiar
@ 2008-02-07 17:21 ` Pierre Ossman
  2008-03-05 19:00   ` Carlos Aguiar
  0 siblings, 1 reply; 3+ messages in thread
From: Pierre Ossman @ 2008-02-07 17:21 UTC (permalink / raw)
  To: Carlos Aguiar; +Cc: Tony Lindgren, linux-kernel

On Mon, 28 Jan 2008 15:07:06 -0400
Carlos Aguiar <carlos.aguiar@indt.org.br> wrote:

> From: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
> 
> This patch adds an include missing from previous merging
> mainline tree into linux-omap tree.
> 
> Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---

NAK. This header should not be needed in host drivers. It's a clear sign you're doing something bad.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 01/18] MMC: OMAP: Include missing from previous merging
  2008-02-07 17:21 ` Pierre Ossman
@ 2008-03-05 19:00   ` Carlos Aguiar
  0 siblings, 0 replies; 3+ messages in thread
From: Carlos Aguiar @ 2008-03-05 19:00 UTC (permalink / raw)
  To: ext Pierre Ossman; +Cc: Tony Lindgren, linux-kernel

ext Pierre Ossman wrote:
> On Mon, 28 Jan 2008 15:07:06 -0400
> Carlos Aguiar <carlos.aguiar@indt.org.br> wrote:
>
>   
>> From: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
>>
>> This patch adds an include missing from previous merging
>> mainline tree into linux-omap tree.
>>
>> Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>> ---
>>     
>
> NAK. This header should not be needed in host drivers. It's a clear sign you're doing something bad.
>
> Rgds
>   
Hi Pierre and folks,

First of all, sorry the delay of this response, I was on vacation for
some weeks.

So, regarding the comments (thanks for all o them) in fact this missing
include is really not needed. So, this patch will be disconsidered when
I resent the series with corrections and comments suggested here.

BR,

Carlos.

-- 
Carlos Eduardo Aguiar
Nokia Institute of Technology - INdT
Open Source Mobile Research Center - OSMRC - Manaus
Core Team
Phone: +55 92 2126-1079
Mobile: +55 92 8127-1797
E-mail: carlos.aguiar@indt.org.br


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-03-05 19:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-28 19:07 [PATCH 01/18] MMC: OMAP: Include missing from previous merging Carlos Aguiar
2008-02-07 17:21 ` Pierre Ossman
2008-03-05 19:00   ` Carlos Aguiar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).