LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Marcin Juszkiewicz <openembedded@haerwu.biz>,
	Christoph Hellwig <hch@infradead.org>, Greg KH <greg@kroah.com>,
	linux-arm-kernel@lists.arm.linux.org.uk,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/arm/Kconfig: Make UIO available on ARM architecture
Date: Thu, 7 Feb 2008 22:05:30 +0100	[thread overview]
Message-ID: <20080207210530.GA22357@uranus.ravnborg.org> (raw)
In-Reply-To: <20080207202940.GI28435@flint.arm.linux.org.uk>

On Thu, Feb 07, 2008 at 08:29:40PM +0000, Russell King - ARM Linux wrote:
> On Thu, Feb 07, 2008 at 09:23:29PM +0100, Sam Ravnborg wrote:
> > +# if PCMCIA is selected then we need IDE
> > +config ARM_PCMCIA
> > +	depends on PCMCIA
> 
> Shouldn't this be:
> 
> 	def_bool PCMCIA
yes - thanks.

> 
> ?
> 
> > +	select HAVE_IDE
> 
> Also, should this be something ARM specific - if you have PCMCIA you could
> have a CF card plugged in, so...  There's nothing ARM specific about that.

So we can replace the above with this:
diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
index 519b4ff..8b22281 100644
--- a/drivers/pcmcia/Kconfig
+++ b/drivers/pcmcia/Kconfig
@@ -38,6 +38,7 @@ config PCMCIA_DEBUG
 config PCMCIA
        tristate "16-bit PCMCIA support"
        select CRC32
+       select HAVE_IDE
        default y
        ---help---
           This option enables support for 16-bit PCMCIA cards. Most older

Makes sense.

> 
> > +
> > +# select MTD except in a few corner configuration cases
> > +config ARM_MTD
> > +	depends on ALIGNMENT_TRAP || !CPU_CP15_MMU
> 
> Ditto.
Yes.

	Sam

  reply	other threads:[~2008-02-07 21:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07 12:38 Hans-Jürgen Koch
2008-02-07 12:58 ` Christoph Hellwig
2008-02-07 13:01   ` Sam Ravnborg
2008-02-07 15:09     ` Marcin Juszkiewicz
2008-02-07 16:05       ` Russell King - ARM Linux
2008-02-07 20:23         ` Sam Ravnborg
2008-02-07 20:29           ` Russell King - ARM Linux
2008-02-07 21:05             ` Sam Ravnborg [this message]
2008-02-08  9:04           ` David Woodhouse
2008-02-08  9:45             ` Russell King - ARM Linux
2008-02-08 10:18               ` David Woodhouse
2008-02-08 10:23                 ` Russell King - ARM Linux
2008-02-08 10:43                   ` David Woodhouse
2008-02-08 10:45                     ` Russell King - ARM Linux
2008-02-12  1:51                       ` Greg Ungerer
2008-02-08 10:58             ` David Woodhouse
2008-02-08 18:46               ` Sam Ravnborg
2008-02-08 18:52                 ` David Woodhouse
2008-02-09 11:39           ` Sam Ravnborg
2008-02-07 14:21   ` Russell King - ARM Linux
2008-02-07 13:02 ` Russell King - ARM Linux
2008-02-07 13:12   ` Hans-Jürgen Koch
2008-02-11  8:25     ` Hans-Jürgen Koch
2008-02-11 14:39       ` Sam Ravnborg
2008-04-10 12:21       ` Uwe Kleine-König
2008-04-10 12:27         ` Russell King - ARM Linux
2008-04-10 12:57           ` Uwe Kleine-König
2008-04-10 13:10             ` Russell King - ARM Linux
2008-04-10 13:50               ` Uwe Kleine-König
2008-04-10 18:58           ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080207210530.GA22357@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=greg@kroah.com \
    --cc=hch@infradead.org \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=openembedded@haerwu.biz \
    --subject='Re: [PATCH] arch/arm/Kconfig: Make UIO available on ARM architecture' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).