LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 2.5/3] palm_bk3710: port initialization/probing bugfix
@ 2008-02-07 20:50 Bartlomiej Zolnierkiewicz
2008-02-08 17:32 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-02-07 20:50 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-ide, Anton Salnikov, Sergei Shtylyov
Probe port _after_ it is fully initialized.
Cc: Anton Salnikov <asalnikov@ru.mvista.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/arm/palm_bk3710.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
Index: b/drivers/ide/arm/palm_bk3710.c
===================================================================
--- a/drivers/ide/arm/palm_bk3710.c
+++ b/drivers/ide/arm/palm_bk3710.c
@@ -370,13 +370,6 @@ static int __devinit palm_bk3710_probe(s
ide_init_port_hw(hwif, &hw);
hwif->quirkproc = NULL;
- idx[0] = i;
-
- ide_device_add(idx, NULL);
-
- if (!hwif->present)
- goto out;
-
hwif->set_pio_mode = &palm_bk3710_set_pio_mode;
hwif->set_dma_mode = &palm_bk3710_set_dma_mode;
hwif->mmio = 1;
@@ -390,6 +383,13 @@ static int __devinit palm_bk3710_probe(s
ide_setup_dma(hwif, mem->start);
+ idx[0] = i;
+
+ ide_device_add(idx, NULL);
+
+ if (!hwif->present)
+ goto out;
+
return 0;
out:
printk(KERN_WARNING "Palm Chip BK3710 IDE Register Fail\n");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.5/3] palm_bk3710: port initialization/probing bugfix
2008-02-07 20:50 [PATCH 2.5/3] palm_bk3710: port initialization/probing bugfix Bartlomiej Zolnierkiewicz
@ 2008-02-08 17:32 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2008-02-08 17:32 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: linux-kernel, linux-ide, Anton Salnikov
Bartlomiej Zolnierkiewicz wrote:
> Probe port _after_ it is fully initialized.
Hm, I thought the usual sequence is vice versa: you first probe and then
initialize. :-)
> Cc: Anton Salnikov <asalnikov@ru.mvista.com>
> Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-08 17:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-07 20:50 [PATCH 2.5/3] palm_bk3710: port initialization/probing bugfix Bartlomiej Zolnierkiewicz
2008-02-08 17:32 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).