LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH -mm] apanel: fix kconfig dependencies
@ 2008-02-07  0:27 Randy Dunlap
  2008-02-07 16:42 ` Jean Delvare
  0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2008-02-07  0:27 UTC (permalink / raw)
  To: lkml; +Cc: khali, shemminger, akpm

From: Randy Dunlap <randy.dunlap@oracle.com>

Add I2C to config since the driver makes several i2c*() calls.

Add PCI to config because the config selects I2C_I801, which depends
on PCI, but currently config* does not follow dependency chains,
so randconfig can enable INPUT_APANEL even when PCI is not enabled,
which leads to these warnings:
linux-2.6.24-mm1/drivers/i2c/busses/i2c-i801.c:641: error: implicit declaration of function 'pci_request_region'
/linux-2.6.24-mm1/drivers/i2c/busses/i2c-i801.c:681: error: implicit declaration of function 'pci_release_region'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/input/misc/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.24-mm1.orig/drivers/input/misc/Kconfig
+++ linux-2.6.24-mm1/drivers/input/misc/Kconfig
@@ -42,7 +42,7 @@ config INPUT_M68K_BEEP
 
 config INPUT_APANEL
 	tristate "Fujitsu Lifebook Application Panel buttons"
-	depends on X86
+	depends on X86 && I2C && PCI
 	select I2C_I801
 	select INPUT_POLLDEV
 	select CHECK_SIGNATURE

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-02-07 21:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-07  0:27 [PATCH -mm] apanel: fix kconfig dependencies Randy Dunlap
2008-02-07 16:42 ` Jean Delvare
2008-02-07 19:04   ` Randy Dunlap
2008-02-07 19:12     ` Stephen Hemminger
2008-02-07 21:46     ` Jean Delvare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).