LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: "Ray Lee" <ray-lk@madrabbit.org>, "Pavel Machek" <pavel@ucw.cz>,
	"kernel list" <linux-kernel@vger.kernel.org>,
	"Linux-pm mailing list" <linux-pm@lists.osdl.org>,
	linux-acpi@vger.kernel.org
Subject: Re: ACPI_WMI: worst config description of all times
Date: Fri, 8 Feb 2008 00:43:02 -0500	[thread overview]
Message-ID: <200802080043.03126.lenb@kernel.org> (raw)
In-Reply-To: <200802080202.41355.carlos@strangeworlds.co.uk>

On Thursday 07 February 2008 21:02, Carlos Corbacho wrote:
> On Friday 08 February 2008 01:38:01 Ray Lee wrote:
> > <nod> That's clear to me (whereas the original wasn't), though I would
> > still argue for this driver being select'ed by the drivers that
> > require it. As you note, other laptop specific drivers do so, and
> > Linus has come down in favor of that as well in the past, so you have
> > a friend in high places :-).
> 
> I have some other patches lined up to do so. Unless I hear some arguments
> against it, or some better alternatives, I'll put them together with this
> and get Len to apply them to the ACPI tree (and then hopefully push back
> out before the -rc1 release).

done.

cheers,
-Len

>From 4a507d93fac78ecd37d18343c57c564f6a126f01 Mon Sep 17 00:00:00 2001
From: Len Brown <len.brown@intel.com>
Date: Fri, 8 Feb 2008 00:37:16 -0500
Subject: [PATCH] acer-wmi, tc1100-wmi: select ACPI_WMI
Organization: Intel Open Source Technology Center

It is safe for these Kconfig entries to use select because
they select ACPI_WMI, which already has its dependencies
satisfied.  This makes Kconfig more user friendly, since
the user selects the driver they want and the dependency
is met for them.  Otherwise, the user would have to find
and enable ACPI_WMI to make enabling these drivers possible.

Signed-off-by: Len Brown <len.brown@intel.com>
---
 drivers/misc/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 218c65a..e19343e 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -97,9 +97,9 @@ config ACER_WMI
 	depends on X86
 	depends on EXPERIMENTAL
 	depends on ACPI
-	depends on ACPI_WMI
 	depends on LEDS_CLASS
 	depends on BACKLIGHT_CLASS_DEVICE
+	select ACPI_WMI
 	---help---
 	  This is a driver for newer Acer (and Wistron) laptops. It adds
 	  wireless radio and bluetooth control, and on some laptops,
@@ -146,7 +146,7 @@ config TC1100_WMI
 	tristate "HP Compaq TC1100 Tablet WMI Extras"
 	depends on X86 && !X86_64
 	depends on ACPI
-	depends on ACPI_WMI
+	select ACPI_WMI
 	---help---
 	  This is a driver for the WMI extensions (wireless and bluetooth power
 	  control) of the HP Compaq TC1100 tablet.
-- 
1.5.4.34.g053d9


  reply	other threads:[~2008-02-08  5:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07 21:47 Pavel Machek
2008-02-07 22:27 ` Len Brown
2008-02-07 22:34   ` Pavel Machek
2008-02-07 23:18     ` Carlos Corbacho
2008-02-07 23:33       ` Ray Lee
2008-02-07 23:51         ` Carlos Corbacho
2008-02-08  0:12           ` Ray Lee
2008-02-08  0:27             ` Carlos Corbacho
2008-02-08  6:53               ` Pavel Machek
2008-02-08  9:37                 ` Carlos Corbacho
2008-02-08  1:19             ` Carlos Corbacho
2008-02-08  1:38               ` Ray Lee
2008-02-08  2:02                 ` Carlos Corbacho
2008-02-08  5:43                   ` Len Brown [this message]
2008-02-08  5:26               ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802080043.03126.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=carlos@strangeworlds.co.uk \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=pavel@ucw.cz \
    --cc=ray-lk@madrabbit.org \
    --subject='Re: ACPI_WMI: worst config description of all times' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).