LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [-mm PATCH] sysdev_unregister() should call kobject_del()
Date: Thu, 7 Feb 2008 21:41:58 -0800	[thread overview]
Message-ID: <20080208054158.GA12742@kroah.com> (raw)
In-Reply-To: <1202447322.13910.3.camel@badari-laptop.beaverton.ibm.com>

On Thu, Feb 07, 2008 at 09:08:42PM -0800, Badari Pulavarty wrote:
> 
> On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote:
> > On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote:
> > > On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote:
> > > > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote:
> > > > > Hi Greg,
> > > > > 
> > > > > While playing with hotplug memory remove on 2.6.24-mm1, I 
> > > > > noticed that /sysfs directory entries are not getting removed.
> > > > > 
> > > > > sysdev_unregister() used to call kobject_unregister().
> > > > > But in 2.6.24-mm1, its only dropping the ref. It should
> > > > > call kobject_del() to remove the object. Correct ?
> > > > > 
> > > > > With this change, the directories are getting removed
> > > > > correctly. Comments ?
> > > > 
> > > > Ick, no, this shouldn't be needed, someone else must be holding a
> > > > reference to the kobject device somewhere.  See the kobject documenation
> > > > for more info.
> > > > 
> > > > I'll try to see where we grab 2 references...
> > > 
> > > I will take a closer look then. I was taking easy way out :(
> > 
> > Hm, I don't see anything obvious in the sys.c core.  What code is
> > controlling these objects that you are creating and removing from the
> > system?
> 
> add_memory_block()/register_memory() is creating sysfs entries
> for the memory blocks.
> 
> I am trying to make use of remove_memory_block() to clean up
> sysfs entries. BTW, remove_memory_block() is never tested
> before, since we don't support memory remove yet.

So how are you testing the sysdev removal logic then if you can't remove
memory?

Oh, one thing, remove the link in unregister_memory, before you call
sysdev_unregister().  You are trying to get the name of a kobject, and
the whole object, that has just been blown away, not nice...

Which makes me believe your statement about this never being tested
before :)

thanks,

greg k-h

  reply	other threads:[~2008-02-08  5:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07 23:56 Badari Pulavarty
2008-02-08  0:38 ` Greg KH
2008-02-08  1:25   ` Badari Pulavarty
2008-02-08  4:55     ` Greg KH
2008-02-08  5:08       ` Badari Pulavarty
2008-02-08  5:41         ` Greg KH [this message]
2008-02-08 16:42           ` Badari Pulavarty
2008-02-08 21:30             ` Dave Hansen
2008-02-08 23:22       ` Badari Pulavarty
2008-02-08 23:57         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080208054158.GA12742@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbadari@us.ibm.com \
    --subject='Re: [-mm PATCH] sysdev_unregister() should call kobject_del()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).