[PATCH] lib/scatterlist.o needed by a module only - link it in unconditionally

[PATCH] lib/scatterlist.o needed by a module only - link it in unconditionally

[Guennadi Liakhovetski]

lib/scatterlist.c is needed by drivers/media/video/videobuf-dma-sg.c, and 
we would like to be able to use the latter without PCI too, for example, 
on PXA270 ARM CPU. It is then possible to create a configuration with 
CONFIG_BLOCK=n, where only module code will need scatterlist.c. Therefore 
it must be in obj-y.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>

---

diff --git a/lib/Makefile b/lib/Makefile
index 543f250..7475da4 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -6,7 +6,7 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \
 	 rbtree.o radix-tree.o dump_stack.o \
 	 idr.o int_sqrt.o extable.o prio_tree.o \
 	 sha1.o irq_regs.o reciprocal_div.o argv_split.o \
-	 proportions.o prio_heap.o scatterlist.o
+	 proportions.o prio_heap.o
 
 lib-$(CONFIG_MMU) += ioremap.o
 lib-$(CONFIG_SMP) += cpumask.o
@@ -14,7 +14,7 @@ lib-$(CONFIG_SMP) += cpumask.o
 lib-y	+= kobject.o kref.o klist.o
 
 obj-y += div64.o sort.o parser.o halfmd4.o debug_locks.o random32.o \
-	 bust_spinlocks.o hexdump.o kasprintf.o bitmap.o
+	 bust_spinlocks.o hexdump.o kasprintf.o bitmap.o scatterlist.o
 
 ifeq ($(CONFIG_DEBUG_KOBJECT),y)
 CFLAGS_kobject.o += -DDEBUG

Re: [PATCH] lib/scatterlist.o needed by a module only - link it in unconditionally

[Jens Axboe]

On Fri, Feb 08 2008, Guennadi Liakhovetski wrote:
> lib/scatterlist.c is needed by drivers/media/video/videobuf-dma-sg.c, and 
> we would like to be able to use the latter without PCI too, for example, 
> on PXA270 ARM CPU. It is then possible to create a configuration with 
> CONFIG_BLOCK=n, where only module code will need scatterlist.c. Therefore 
> it must be in obj-y.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>

Acked-by: Jens Axboe <jens.axboe@oracle.com>

Andrew, can I ask you to take care of this?

-- 
Jens Axboe

Re: [PATCH] lib/scatterlist.o needed by a module only - link it in unconditionally

[Andrew Morton]

On Fri, 8 Feb 2008 21:46:11 +0100
Jens Axboe <jens.axboe@oracle.com> wrote:

> On Fri, Feb 08 2008, Guennadi Liakhovetski wrote:
> > lib/scatterlist.c is needed by drivers/media/video/videobuf-dma-sg.c, and 
> > we would like to be able to use the latter without PCI too, for example, 
> > on PXA270 ARM CPU. It is then possible to create a configuration with 
> > CONFIG_BLOCK=n, where only module code will need scatterlist.c. Therefore 
> > it must be in obj-y.
> > 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de>
> 
> Acked-by: Jens Axboe <jens.axboe@oracle.com>
> 
> Andrew, can I ask you to take care of this?

sure..