LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Paul Clements <paul.clements@steeleye.com>
Cc: jens.axboe@oracle.com, randy.dunlap@oracle.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] NBD: make nbd default to deadline I/O scheduler
Date: Fri, 8 Feb 2008 14:02:44 -0800	[thread overview]
Message-ID: <20080208140244.c850a5d3.akpm@linux-foundation.org> (raw)
In-Reply-To: <47ACC835.4070102@steeleye.com>

On Fri, 08 Feb 2008 16:23:01 -0500
Paul Clements <paul.clements@steeleye.com> wrote:

> --- ./drivers/block/nbd.c.max_nbd_killed	2008-02-07 16:46:24.000000000 -0500
> +++ ./drivers/block/nbd.c	2008-02-08 16:13:01.000000000 -0500
> @@ -667,6 +667,12 @@ static int __init nbd_init(void)
>  			put_disk(disk);
>  			goto out;
>  		}
> +		if (elevator_init(disk->queue, "deadline") != 0) {
> +			if (elevator_init(disk->queue, "noop") != 0) {
> +				put_disk(disk);
> +				goto out;
> +			}
> +		}
>  	}

- if the user doesn't have deadline or noop configured, NBD will now
  fail.  That's a non-backward-compatible change.

- when it fails, it will fail silently.  Puzzled and angry users.

- when it fails, it will inappropriately return -ENOMEM.

  reply	other threads:[~2008-02-08 22:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 16:47 Paul Clements
2008-02-08 17:33 ` Randy Dunlap
2008-02-08 18:11   ` Andrew Morton
2008-02-08 18:41     ` Paul Clements
2008-02-08 20:45       ` Jens Axboe
2008-02-08 20:47         ` Jens Axboe
2008-02-08 21:23           ` Paul Clements
2008-02-08 22:02             ` Andrew Morton [this message]
2008-02-09 13:30               ` Paul Clements
2008-02-12 23:16                 ` Andrew Morton
2008-02-18 18:16                   ` Jens Axboe
2008-02-18 23:50                     ` Andrew Morton
2008-02-19  9:19                       ` Jens Axboe
2008-02-19  9:24                         ` Jens Axboe
2008-02-19 10:02                           ` Andrew Morton
2008-02-19 10:05                             ` Jens Axboe
2008-02-08 22:45       ` [Nbd] " Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080208140244.c850a5d3.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.clements@steeleye.com \
    --cc=randy.dunlap@oracle.com \
    --subject='Re: [PATCH 1/1] NBD: make nbd default to deadline I/O scheduler' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).