LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Dmitry Torokhov <dtor@insightbb.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] Input updates for 2.6.25-rc0
Date: Fri, 8 Feb 2008 15:28:12 -0800	[thread overview]
Message-ID: <20080208152812.2bb14374@extreme> (raw)
In-Reply-To: <20080208232536.GA15727@elte.hu>

On Sat, 9 Feb 2008 00:25:36 +0100
Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Dmitry Torokhov <dtor@insightbb.com> wrote:
> 
> > Stephen Hemminger (2):
> >       Input: add driver for Fujitsu application buttons
> 
> this change broke the build on x86 in randconfig testing:
> 
>   drivers/built-in.o: In function `apanel_detach_client':
>   apanel.c:(.text+0x15c120): undefined reference to  `__led_classdev_unregister'
>   drivers/built-in.o: In function `apanel_probe':
>   apanel.c:(.text+0x15c30f): undefined reference to  `led_classdev_register'
> 
> .config attached.
> 
> the Kconfig dependencies seem incomplete:
> 
> > +config INPUT_APANEL
> > +     tristate "Fujitsu Lifebook Application Panel buttons"
> > +     depends on X86
> > +     select I2C_I801
> > +     select INPUT_POLLDEV
> > +     select CHECK_SIGNATURE
> > +     help
> 
> it doesnt list LEDS.
> 
> 	Ingo

I think someone already sent a patch to select the LEDS

-- 
Stephen Hemminger <stephen.hemminger@vyatta.com>

  reply	other threads:[~2008-02-08 23:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06  6:08 Dmitry Torokhov
2008-02-06  6:32 ` Andrew Morton
2008-02-06  6:49   ` Dmitry Torokhov
2008-02-06  7:56     ` Sam Ravnborg
2008-02-06 14:19       ` Dmitry Torokhov
2008-02-07 20:05   ` Dmitry Torokhov
2008-02-07 21:00     ` Andrew Morton
2008-02-06  7:00 ` Andrew Morton
2008-02-08 23:25 ` Ingo Molnar
2008-02-08 23:28   ` Stephen Hemminger [this message]
2008-02-08 23:37     ` [patch] " Randy Dunlap
2008-02-08 23:49       ` Jesper Juhl
2008-02-08 23:54       ` Andrew Morton
2008-02-09  0:00         ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080208152812.2bb14374@extreme \
    --to=shemminger@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=dtor@insightbb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [git pull] Input updates for 2.6.25-rc0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).