LKML Archive on
help / color / mirror / Atom feed
From: Konrad Rzeszutek <>
To: James Bottomley <>
Cc: Andrew Morton <>,, Greg KH <>,,,,,,,,,,,,,
	Andy Whitcroft <>
Subject: Re: [PATCH] Add iSCSI iBFT support (v0.4.6)
Date: Fri, 8 Feb 2008 15:37:17 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <1201911489.3134.79.camel@localhost.localdomain>

On Friday 01 February 2008 19:18:09 James Bottomley wrote:
> On Wed, 2008-01-30 at 17:37 -0400, Konrad Rzeszutek wrote:
> > This patch (v0.4.6) adds

> Some pieces of the patch are obviously wrong:  find_ibft() shouldn't be
> in ibft_init ... if ibft_phys was zero, it means the bootmem reservation
> wasn't done and you shouldn't be poking about in memory which has likely
> now been overwritten.
> Also, why is ibft_phys the global variable you pass?  You never actually
> want to use the physical address, what you always end up using is the
> kernel virtual address.
> I'd simply use the ibft variable to point to the virtual address of the
> ibft or null if not found, then you can throw out all the phys_to_virt()
> calls.
> Also, move the reserve_bootmem into the ibft_find routines and ensure
> they're only called once on boot.  Refuse to attach the ibft driver if
> the virtual pointer ibft is null.


Thanks for your review. If you wouldn't mind, can you take a look
at the version 0.4.7 ( which has your 
suggestions incorporated.

Thanks again.

      parent reply	other threads:[~2008-02-08 20:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 21:37 Konrad Rzeszutek
2008-02-02  0:18 ` James Bottomley
2008-02-02  0:44   ` Andrew Morton
2008-02-08 20:37   ` Konrad Rzeszutek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] Add iSCSI iBFT support (v0.4.6)' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).