LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Dmitry Torokhov <dtor@insightbb.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [patch] [git pull] Input updates for 2.6.25-rc0
Date: Fri, 8 Feb 2008 15:37:41 -0800	[thread overview]
Message-ID: <20080208153741.54409a7a.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20080208152812.2bb14374@extreme>

On Fri, 8 Feb 2008 15:28:12 -0800 Stephen Hemminger wrote:

> On Sat, 9 Feb 2008 00:25:36 +0100
> Ingo Molnar <mingo@elte.hu> wrote:
> 
> > 
> > * Dmitry Torokhov <dtor@insightbb.com> wrote:
> > 
> > > Stephen Hemminger (2):
> > >       Input: add driver for Fujitsu application buttons
> > 
> > this change broke the build on x86 in randconfig testing:
> > 
> >   drivers/built-in.o: In function `apanel_detach_client':
> >   apanel.c:(.text+0x15c120): undefined reference to  `__led_classdev_unregister'
> >   drivers/built-in.o: In function `apanel_probe':
> >   apanel.c:(.text+0x15c30f): undefined reference to  `led_classdev_register'
> > 
> > .config attached.
> > 
> > the Kconfig dependencies seem incomplete:
> > 
> > > +config INPUT_APANEL
> > > +     tristate "Fujitsu Lifebook Application Panel buttons"
> > > +     depends on X86
> > > +     select I2C_I801
> > > +     select INPUT_POLLDEV
> > > +     select CHECK_SIGNATURE
> > > +     help
> > 
> > it doesnt list LEDS.
> > 
> > 	Ingo
> 
> I think someone already sent a patch to select the LEDS

I did... and more.  Who will merge it?  (below)

---
From: Randy Dunlap <randy.dunlap@oracle.com>

Add I2C to config since the driver makes several i2c*() calls.

Add to help text that the Intel I2C ICH (i801) driver is also needed
for this kernel.

Add LEDS_CLASS to config since the driver makes les_classdev_*() calls:
ERROR: "led_classdev_register" [drivers/input/misc/apanel.ko] undefined!
ERROR: "__led_classdev_unregister" [drivers/input/misc/apanel.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/input/misc/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-2.6.24-mm1.orig/drivers/input/misc/Kconfig
+++ linux-2.6.24-mm1/drivers/input/misc/Kconfig
@@ -42,14 +42,14 @@ config INPUT_M68K_BEEP
 
 config INPUT_APANEL
 	tristate "Fujitsu Lifebook Application Panel buttons"
-	depends on X86
-	select I2C_I801
+	depends on X86 && I2C && LEDS_CLASS
 	select INPUT_POLLDEV
 	select CHECK_SIGNATURE
 	help
 	 Say Y here for support of the Application Panel buttons, used on
 	 Fujitsu Lifebook. These are attached to the mainboard through
-	 an SMBus interface managed by the I2C Intel ICH (i801) driver.
+	 an SMBus interface managed by the I2C Intel ICH (i801) driver,
+	 which you should also build for this kernel.
 
 	 To compile this driver as a module, choose M here: the module will
 	 be called apanel.

  reply	other threads:[~2008-02-08 23:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06  6:08 Dmitry Torokhov
2008-02-06  6:32 ` Andrew Morton
2008-02-06  6:49   ` Dmitry Torokhov
2008-02-06  7:56     ` Sam Ravnborg
2008-02-06 14:19       ` Dmitry Torokhov
2008-02-07 20:05   ` Dmitry Torokhov
2008-02-07 21:00     ` Andrew Morton
2008-02-06  7:00 ` Andrew Morton
2008-02-08 23:25 ` Ingo Molnar
2008-02-08 23:28   ` Stephen Hemminger
2008-02-08 23:37     ` Randy Dunlap [this message]
2008-02-08 23:49       ` [patch] " Jesper Juhl
2008-02-08 23:54       ` Andrew Morton
2008-02-09  0:00         ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080208153741.54409a7a.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=dtor@insightbb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=shemminger@linux-foundation.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [patch] [git pull] Input updates for 2.6.25-rc0' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).