LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	arjan@infradead.org, linux-pcmcia@lists.infradead.org,
	Greg KH <greg@kroah.com>
Subject: Re: [PATCH] pcmcia: fix i82092 printk format
Date: Fri, 8 Feb 2008 15:53:19 -0800	[thread overview]
Message-ID: <20080208155319.dfc584c8.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080208152244.8aa5fdbb.randy.dunlap@oracle.com>

On Fri, 8 Feb 2008 15:22:44 -0800 Randy Dunlap <randy.dunlap@oracle.com> wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix printk format warnings:
> linux-2.6.24-git19/drivers/pcmcia/i82092.c:650: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'resource_size_t'
> linux-2.6.24-git19/drivers/pcmcia/i82092.c:650: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'resource_size_t'
> 
> Fix very long source line size.
> Fix spacing within the printk format string.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/pcmcia/i82092.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> --- linux-2.6.24-git19.orig/drivers/pcmcia/i82092.c
> +++ linux-2.6.24-git19/drivers/pcmcia/i82092.c
> @@ -647,7 +647,9 @@ static int i82092aa_set_mem_map(struct p
>  	if ( (mem->card_start > 0x3ffffff) || (region.start > region.end) ||
>  	     (mem->speed > 1000) ) {
>  		leave("i82092aa_set_mem_map: invalid address / speed");
> -		printk("invalid mem map for socket %i : %lx to %lx with a start of %x \n",sock,region.start, region.end, mem->card_start);
> +		printk("invalid mem map for socket %i: %llx to %llx with a start of %x\n",
> +			sock, (unsigned long long)region.start,
> +			(unsigned long long)region.end, mem->card_start);
>  		return -EINVAL;
>  	}
>  	

I've apleady sent a similar patch to Greg
(drivers-pcmcia-i82092c-fix-up-after-pci_bus_region-changes.patch) but I
imagine he's swamped with -stable fun and games at present.


      reply	other threads:[~2008-02-08 23:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 23:22 Randy Dunlap
2008-02-08 23:53 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080208155319.dfc584c8.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=randy.dunlap@oracle.com \
    --subject='Re: [PATCH] pcmcia: fix i82092 printk format' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).