LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Trond.Myklebust@netapp.com, chuck.lever@oracle.com
Cc: nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, selinux@tycho.nsa.gov,
	linux-security-module@vger.kernel.org, dhowells@redhat.com
Subject: [PATCH 21/37] NFS: Add comment banners to some NFS functions
Date: Fri, 08 Feb 2008 16:53:50 +0000	[thread overview]
Message-ID: <20080208165350.15902.18047.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <20080208165156.15902.62457.stgit@warthog.procyon.org.uk>

Add comment banners to some NFS functions so that they can be modified by the
NFS fscache patches for further information.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/nfs/file.c |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)


diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index ef57a5a..26a073b 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -354,6 +354,13 @@ static int nfs_write_end(struct file *file, struct address_space *mapping,
 	return copied;
 }
 
+/*
+ * Partially or wholly invalidate a page
+ * - Release the private state associated with a page if undergoing complete
+ *   page invalidation
+ * - Called if either PG_private or PG_private_2 is set on the page
+ * - Caller holds page lock
+ */
 static void nfs_invalidate_page(struct page *page, unsigned long offset)
 {
 	if (offset != 0)
@@ -362,12 +369,26 @@ static void nfs_invalidate_page(struct page *page, unsigned long offset)
 	nfs_wb_page_cancel(page->mapping->host, page);
 }
 
+/*
+ * Attempt to release the private state associated with a page
+ * - Called if either PG_private or PG_private_2 is set on the page
+ * - Caller holds page lock
+ * - Return true (may release page) or false (may not)
+ */
 static int nfs_release_page(struct page *page, gfp_t gfp)
 {
 	/* If PagePrivate() is set, then the page is not freeable */
 	return 0;
 }
 
+/*
+ * Attempt to clear the private state associated with a page when an error
+ * occurs that requires the cached contents of an inode to be written back or
+ * destroyed
+ * - Called if either PG_private or PG_private_2 is set on the page
+ * - Caller holds page lock
+ * - Return 0 if successful, -error otherwise
+ */
 static int nfs_launder_page(struct page *page)
 {
 	return nfs_wb_page(page->mapping->host, page);
@@ -389,6 +410,11 @@ const struct address_space_operations nfs_file_aops = {
 	.launder_page = nfs_launder_page,
 };
 
+/*
+ * Notification that a PTE pointing to an NFS page is about to be made
+ * writable, implying that someone is about to modify the page through a
+ * shared-writable mapping
+ */
 static int nfs_vm_page_mkwrite(struct vm_area_struct *vma, struct page *page)
 {
 	struct file *filp = vma->vm_file;


  parent reply	other threads:[~2008-02-08 17:09 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 16:51 [PATCH 00/37] Permit filesystem local caching David Howells
2008-02-08 16:52 ` [PATCH 01/37] KEYS: Increase the payload size when instantiating a key David Howells
2008-02-08 16:52 ` [PATCH 02/37] KEYS: Check starting keyring as part of search David Howells
2008-02-08 16:52 ` [PATCH 03/37] KEYS: Allow the callout data to be passed as a blob rather than a string David Howells
2008-02-08 16:52 ` [PATCH 04/37] KEYS: Add keyctl function to get a security label David Howells
2008-02-08 16:52 ` [PATCH 05/37] Security: Change current->fs[ug]id to current_fs[ug]id() David Howells
2008-02-11 10:38   ` James Morris
2008-02-08 16:52 ` [PATCH 06/37] Security: Separate task security context from task_struct David Howells
2008-02-11 10:43   ` James Morris
2008-02-08 16:52 ` [PATCH 07/37] Security: De-embed task security record from task and use refcounting David Howells
2008-02-11 10:57   ` James Morris
2008-02-11 17:30   ` David Howells
2008-02-11 18:48     ` Stephen Smalley
2008-02-08 16:52 ` [PATCH 08/37] Security: Add a kernel_service object class to SELinux David Howells
2008-02-11 10:59   ` James Morris
2008-02-08 16:52 ` [PATCH 09/37] Security: Allow kernel services to override LSM settings for task actions David Howells
2008-02-08 16:52 ` [PATCH 10/37] Security: Make NFSD work with detached security David Howells
2008-02-08 16:52 ` [PATCH 11/37] FS-Cache: Release page->private after failed readahead David Howells
2008-02-08 16:53 ` [PATCH 12/37] FS-Cache: Recruit a couple of page flags for cache management David Howells
2008-02-08 16:53 ` [PATCH 13/37] FS-Cache: Provide an add_wait_queue_tail() function David Howells
2008-02-08 16:53 ` [PATCH 14/37] FS-Cache: Generic filesystem caching facility David Howells
2008-02-08 16:53 ` [PATCH 15/37] CacheFiles: Add missing copy_page export for ia64 David Howells
2008-02-08 16:53 ` [PATCH 16/37] CacheFiles: Be consistent about the use of mapping vs file->f_mapping in Ext3 David Howells
2008-02-08 16:53 ` [PATCH 17/37] CacheFiles: Add a hook to write a single page of data to an inode David Howells
2008-02-08 16:53 ` [PATCH 18/37] CacheFiles: Permit the page lock state to be monitored David Howells
2008-02-08 16:53 ` [PATCH 19/37] CacheFiles: Export things for CacheFiles David Howells
2008-02-08 16:53 ` [PATCH 20/37] CacheFiles: A cache that backs onto a mounted filesystem David Howells
2008-02-08 16:53 ` David Howells [this message]
2008-02-08 16:53 ` [PATCH 22/37] NFS: Add FS-Cache option bit and debug bit David Howells
2008-02-08 16:54 ` [PATCH 23/37] NFS: Permit local filesystem caching to be enabled for NFS David Howells
2008-02-08 16:54 ` [PATCH 24/37] NFS: Register NFS for caching and retrieve the top-level index David Howells
2008-02-08 16:54 ` [PATCH 25/37] NFS: Define and create server-level objects David Howells
2008-02-08 16:54 ` [PATCH 26/37] NFS: Define and create superblock-level objects David Howells
2008-02-08 16:54 ` [PATCH 27/37] NFS: Define and create inode-level cache objects David Howells
2008-02-08 16:54 ` [PATCH 28/37] NFS: Use local disk inode cache David Howells
2008-02-08 16:54 ` [PATCH 29/37] NFS: Invalidate FsCache page flags when cache removed David Howells
2008-02-08 16:54 ` [PATCH 30/37] NFS: Add some new I/O event counters for FS-Cache events David Howells
2008-02-08 16:54 ` [PATCH 31/37] NFS: FS-Cache page management David Howells
2008-02-08 16:54 ` [PATCH 32/37] NFS: Add read context retention for FS-Cache to call back with David Howells
2008-02-08 16:54 ` [PATCH 33/37] NFS: nfs_readpage_async() needs to be accessible as a fallback for local caching David Howells
2008-02-08 16:54 ` [PATCH 34/37] NFS: Read pages from FS-Cache into an NFS inode David Howells
2008-02-08 16:55 ` [PATCH 35/37] NFS: Store pages from an NFS inode into a local cache David Howells
2008-02-08 16:55 ` [PATCH 36/37] NFS: Display local caching state David Howells
2008-02-08 16:55 ` [PATCH 37/37] NFS: Add mount options to enable local caching on NFS David Howells
2008-02-20 16:05 [PATCH 00/37] Permit filesystem local caching David Howells
2008-02-20 16:07 ` [PATCH 21/37] NFS: Add comment banners to some NFS functions David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080208165350.15902.18047.stgit@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=nfsv4@linux-nfs.org \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).