LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Rodolfo Giometti <giometti@linux.it>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	David Woodhouse <dwmw2@infradead.org>,
	Dave Jones <davej@redhat.com>
Subject: Re: [PATCH 1/8] LinuxPPS core support.
Date: Fri, 8 Feb 2008 20:11:10 +0100	[thread overview]
Message-ID: <20080208191110.GB31072@uranus.ravnborg.org> (raw)
In-Reply-To: <120249364418-git-send-email-giometti@linux.it>

Hi Rodolfo.

Kconfig bits are trivial and looks OK.

> diff --git a/drivers/pps/Makefile b/drivers/pps/Makefile
> new file mode 100644
> index 0000000..5a9a51b
> --- /dev/null
> +++ b/drivers/pps/Makefile
> @@ -0,0 +1,10 @@
> +#
> +# Makefile for the PPS core.
> +#
> +
> +pps_core-objs			+= pps.o kapi.o sysfs.o
> +obj-$(CONFIG_PPS)		+= pps_core.o

Please use:
pps_core-y        := pps.o kapi.o sysfs.o
obj-$(CONFIG_PPS) := pps_core.o

The change from '+=' to ':=' is purely cosmetic
but I prefer this way to make it explicit that the
variables contain no other values.

> +
> +ifeq ($(CONFIG_PPS_DEBUG),y)
> +EXTRA_CFLAGS += -DDEBUG
> +endif
And this we do so today:
ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG


I did not look at the code so do not consider it reviewed by
this feedback.

	Sam


  parent reply	other threads:[~2008-02-08 19:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 18:00 LinuxPPS: the PPS Linux implementation Rodolfo Giometti
2008-02-08 18:00 ` [PATCH 1/8] LinuxPPS core support Rodolfo Giometti
2008-02-08 18:00   ` [PATCH 2/8] PPS: basic documentation file Rodolfo Giometti
2008-02-08 18:00     ` [PATCH 3/8] PPS: userland header file for PPS API Rodolfo Giometti
2008-02-08 18:00       ` [PATCH 4/8] PPS: documentation programs and examples Rodolfo Giometti
2008-02-08 18:00         ` [PATCH 5/8] PPS: LinuxPPS clients support Rodolfo Giometti
2008-02-08 18:00           ` [PATCH 6/8] PPS: serial " Rodolfo Giometti
2008-02-08 18:00             ` [PATCH 7/8] PPS: example program to enable PPS support on serial ports Rodolfo Giometti
2008-02-08 18:00               ` [PATCH 8/8] PPS: parallel port clients support Rodolfo Giometti
2008-02-08 19:11   ` Sam Ravnborg [this message]
2008-02-09  6:45   ` [PATCH 1/8] LinuxPPS core support Greg KH
2008-02-11  9:53     ` Rodolfo Giometti
2008-02-11 15:25       ` Greg KH
2008-02-11 18:31         ` Rodolfo Giometti
2008-02-11 18:42           ` Rodolfo Giometti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080208191110.GB31072@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=davej@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=giometti@linux.it \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/8] LinuxPPS core support.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).