LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Balaji Rao <balajirrao@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] kobject handling in cpufreq
Date: Fri, 8 Feb 2008 11:39:27 -0800	[thread overview]
Message-ID: <20080208193927.GA25989@suse.de> (raw)
In-Reply-To: <200802090052.40939.balajirrao@gmail.com>

On Sat, Feb 09, 2008 at 12:52:40AM +0530, Balaji Rao wrote:
> Hi greg,
> 
> I encountered a regression in linux-2.6.git which prevented the system from shutting down. I found that it 
> was 'waiting_for_completion' on kobj_unregister.The same thing happened when I tried to take CPUs offline.
> 
> git-bisect pointed me to this commit :
> 
> commit c10997f6575f476ff38442fa18fd4a0d80345f9d
> Author: Greg Kroah-Hartman <gregkh@suse.de>
> Date:   Thu Dec 20 08:13:05 2007 -0800
> 
>     Kobject: convert drivers/* from kobject_unregister() to kobject_put()
> 
> In the file drivers/cpufreq/cpufreq.c, you have not replaced one occurrence of kobject_unregister with kobject_put. 
> Apparently its because of the kobject_put in the subsequent line.
> 
> @@ -1030,8 +1030,6 @@ static int __cpufreq_remove_dev (struct sys_device * sys_dev)
>  
>         unlock_policy_rwsem_write(cpu);
>  
> -       kobject_unregister(&data->kobj);
> -
>         kobject_put(&data->kobj);
>  
>         /* we need to make sure that the underlying kobj is actually
> 
> Now, this can be fixed by adding another kobject_put. But having two kobject_puts in consequent lines tells us that there 
> should be two references to the kobject at that point. So, I believe that it is safe to remove the kobject_get 
> corresponding to the existing kobject_put to fix this.
> 
> Signed-off-by: Balaji Rao <balajirrao@gmail.com>

This looks correct to me, nice catch.

Acked-by: Greg Kroah-Hartman <gregkh@suse.de>

thanks,

greg k-h

      reply	other threads:[~2008-02-08 19:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 19:22 Balaji Rao
2008-02-08 19:39 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080208193927.GA25989@suse.de \
    --to=gregkh@suse.de \
    --cc=balajirrao@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [REGRESSION] kobject handling in cpufreq' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).