LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	<linux-kernel@vger.kernel.org>, Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH 1/1] tty: BKL pushdown fix1
Date: Fri, 8 Feb 2008 21:50:17 +0000	[thread overview]
Message-ID: <20080208215017.332c3480@core> (raw)
In-Reply-To: <1202506856-3403-1-git-send-email-jirislaby@gmail.com>

On Fri,  8 Feb 2008 22:40:56 +0100
Jiri Slaby <jirislaby@gmail.com> wrote:

> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> ---
>  fs/compat_ioctl.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
> index c6e72ae..9663e87 100644
> --- a/fs/compat_ioctl.c
> +++ b/fs/compat_ioctl.c
> @@ -1046,7 +1046,7 @@ static int vt_check(struct file *file)
>  	struct inode *inode = file->f_path.dentry->d_inode;
>  	struct vc_data *vc;
>  	
> -	if (file->f_op->ioctl != tty_ioctl)
> +	if (file->f_op->unlocked_ioctl != tty_ioctl)
>  		return -EINVAL;

Acked-by: Alan Cox <alan@redhat.com>

Nice catch

  parent reply	other threads:[~2008-02-08 21:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 15:42 [PATCH] tty: BKL pushdown Alan Cox
2008-02-08 19:04 ` [PATCH 1/1] tty: BKL pushdown fix Jiri Slaby
2008-02-08 21:35   ` Andrew Morton
2008-02-08 21:38     ` Jiri Slaby
2008-02-08 21:40       ` [PATCH 1/1] tty: BKL pushdown fix1 Jiri Slaby
2008-02-08 21:42         ` Jiri Slaby
2008-02-08 21:50         ` Alan Cox [this message]
2008-02-08 22:11       ` [PATCH 1/1] tty: BKL pushdown fix Andrew Morton
2008-02-08 22:15         ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080208215017.332c3480@core \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/1] tty: BKL pushdown fix1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).