LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: CONFIG_HIGHPTE vs. sub-page page tables.
Date: Sat, 9 Feb 2008 00:15:06 +0100	[thread overview]
Message-ID: <20080208231506.GA13350@elte.hu> (raw)
In-Reply-To: <20080208230433.GA8524@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> config attached. It seems all !PAE 32-bit kernel builds are broken due 
> to this. The patch below fixes it.

ok, the patch was against x86.git which had some other changes in this 
area - the one below applies to vanilla -git and fixes the bug.

	Ingo

----------------->
Subject: x86: fix pgtable_t build breakage
From: Ingo Molnar <mingo@elte.hu>

fix build breakage caused by commit 2f569afd9ced9ebec9.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 include/asm-x86/page_32.h |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Index: linux-x86.q/include/asm-x86/page_32.h
===================================================================
--- linux-x86.q.orig/include/asm-x86/page_32.h
+++ linux-x86.q/include/asm-x86/page_32.h
@@ -50,11 +50,13 @@ typedef unsigned long	phys_addr_t;
 typedef union { pteval_t pte, pte_low; } pte_t;
 typedef pte_t boot_pte_t;
 
-typedef struct page *pgtable_t;
-
 #endif	/* __ASSEMBLY__ */
 #endif	/* CONFIG_X86_PAE */
 
+#ifndef __ASSEMBLY__
+typedef struct page *pgtable_t;
+#endif
+
 #ifdef CONFIG_HUGETLB_PAGE
 #define HAVE_ARCH_HUGETLB_UNMAPPED_AREA
 #endif

  reply	other threads:[~2008-02-08 23:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200802081902.m18J2nOm005840@hera.kernel.org>
2008-02-08 23:04 ` Ingo Molnar
2008-02-08 23:15   ` Ingo Molnar [this message]
2008-02-09 10:06     ` Martin Schwidefsky
2008-02-09 10:37       ` Ingo Molnar
2008-02-09 10:56         ` Martin Schwidefsky
2008-02-09 17:56           ` Mike Frysinger
2008-02-10  9:17             ` Martin Schwidefsky
2008-02-10  9:25               ` Mike Frysinger
2008-02-10  9:41                 ` Martin Schwidefsky
2008-02-10 10:06                   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080208231506.GA13350@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: CONFIG_HIGHPTE vs. sub-page page tables.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).