* Len Brown <lenb@kernel.org> wrote:

> Len Brown (6):
>       ACPI: add newline to printk
>       ACPI: build WMI on X86 only
>       acer-wmi, tc1100-wmi: select ACPI_WMI

hm, this new WMI code caused a bootup crash in the overnight x86.git 
tests:

initcall 0x40cffbd0 ran for 0 msecs: msi_init+0x0/0x150()
Calling initcall 0x40cffd20: tc1100_init+0x0/0x70()
BUG: unable to handle kernel NULL pointer dereference at 00000000
IP: [<404b96a2>] find_guid+0x132/0x150
*pde = 00000000 
Oops: 0000 [#1] SMP 

Pid: 1, comm: swapper Not tainted (2.6.24 #34)
EIP: 0060:[<404b96a2>] EFLAGS: 00010247 CPU: 1
EIP is at find_guid+0x132/0x150
EAX: 05a572d4 EBX: 5f81af54 ECX: 00000000 EDX: ffffffff
ESI: 00000000 EDI: 5f81af54 EBP: 5f81af80 ESP: 5f81af48
 DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
Process swapper (pid: 1, ti=5f81a000 task=5f815410 task.ti=5f81a000)
Stack: 00000000 5f81af74 00000005 c364ac71 495a36db 39b49484 05a572d4 71ac64c3 
       5a49db36 39b49484 05a572d4 00000000 00000000 ffffffed 5f81af88 404b96cf 
       5f81af94 40cffd33 00000000 5f81afe0 40cdb5d3 2c7b1366 00000001 00000000 
Call Trace:
 [<404b96cf>] ? wmi_has_guid+0xf/0x20
 [<40cffd33>] ? tc1100_init+0x13/0x70
 [<40cdb5d3>] ? kernel_init+0x123/0x2f0
 [<40cdb4b0>] ? kernel_init+0x0/0x2f0
 [<401053d7>] ? kernel_thread_helper+0x7/0x10
 =======================
Code: 0c 41 8d 7d d4 eb 24 8d 46 08 b9 10 00 00 00 89 fa e8 e3 88 f6 ff 85 c0 75 0f b0 01 83 7d c8 00 74 19 8b 55 c8 89 32 eb 12 89 de <8b> 1e 0f 18 03 90 81 fe 90 c1 0c 41 75 ce 31 c0 83 c4 2c 5b 5e 
EIP: [<404b96a2>] find_guid+0x132/0x150 SS:ESP 0068:5f81af48
---[ end trace 5d95b7a12e9c31b7 ]---
Kernel panic - not syncing: Attempted to kill init!
Press any key to enter the menu

config and crashlog attached.

I double-checked a second bootup [with a slightly different but 
essentially same kernel], but this time the crash did not happen:

 Calling initcall 0x40cb8b80: acpi_wmi_init+0x0/0x50()
 ACPI: WMI: Mapper loaded
 initcall 0x40cb8b80: acpi_wmi_init+0x0/0x50() returned 0.
 initcall 0x40cb8b80 ran for 0 msecs: acpi_wmi_init+0x0/0x50()

 Calling initcall 0x40cbd770: tc1100_init+0x0/0x60()
 initcall 0x40cbd770: tc1100_init+0x0/0x60() returned -19.
 initcall 0x40cbd770 ran for 0 msecs: tc1100_init+0x0/0x60()

[ the weird addresses are due to a 1:3 GB VM split being configured by
  randconfig. ]

	Ingo