LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Erez Zadok <ezk@cs.sunysb.edu>
Cc: Christoph Hellwig <hch@lst.de>,
akpm@osdl.org, rdunlap@xenotime.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix up kerneldoc in fs/ioctl.c a little bit
Date: Sat, 9 Feb 2008 08:22:42 +0100 [thread overview]
Message-ID: <20080209072242.GA31231@lst.de> (raw)
In-Reply-To: <200802090719.m197JRan023715@agora.fsl.cs.sunysb.edu>
On Sat, Feb 09, 2008 at 02:19:27AM -0500, Erez Zadok wrote:
> > * Invokes filesystem specific ->unlocked_ioctl, if one exists; otherwise
> > * invokes * filesystem specific ->ioctl method. If neither method exists,
> ^
>
> I also think this extra '*' in the last comment line above is spurious,
> perhaps the result of a paragraph reformatting command that mixed comment
> *'s with text.
Indeed. Updated patch below:
Index: linux-2.6/fs/ioctl.c
===================================================================
--- linux-2.6.orig/fs/ioctl.c 2008-02-09 07:51:31.000000000 +0100
+++ linux-2.6/fs/ioctl.c 2008-02-09 08:21:30.000000000 +0100
@@ -18,12 +18,12 @@
/**
* vfs_ioctl - call filesystem specific ioctl methods
- * @filp: [in] open file to invoke ioctl method on
- * @cmd: [in] ioctl command to execute
- * @arg: [in/out] command-specific argument for ioctl
+ * @filp: open file to invoke ioctl method on
+ * @cmd: ioctl command to execute
+ * @arg: command-specific argument for ioctl
*
* Invokes filesystem specific ->unlocked_ioctl, if one exists; otherwise
- * invokes * filesystem specific ->ioctl method. If neither method exists,
+ * invokes filesystem specific ->ioctl method. If neither method exists,
* returns -ENOTTY.
*
* Returns 0 on success, -errno on error.
prev parent reply other threads:[~2008-02-09 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-09 7:15 Christoph Hellwig
2008-02-09 7:19 ` Erez Zadok
2008-02-09 7:22 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080209072242.GA31231@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=ezk@cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--subject='Re: [PATCH] fix up kerneldoc in fs/ioctl.c a little bit' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).