LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] fix up kerneldoc in fs/ioctl.c a little bit
@ 2008-02-09 7:15 Christoph Hellwig
2008-02-09 7:19 ` Erez Zadok
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2008-02-09 7:15 UTC (permalink / raw)
To: akpm, ezk, rdunlap; +Cc: linux-kernel
- remove non-standard in/out markers
- use tabs for formatting
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/fs/ioctl.c
===================================================================
--- linux-2.6.orig/fs/ioctl.c 2008-02-09 07:49:02.000000000 +0100
+++ linux-2.6/fs/ioctl.c 2008-02-09 07:49:20.000000000 +0100
@@ -18,9 +18,9 @@
/**
* vfs_ioctl - call filesystem specific ioctl methods
- * @filp: [in] open file to invoke ioctl method on
- * @cmd: [in] ioctl command to execute
- * @arg: [in/out] command-specific argument for ioctl
+ * @filp: open file to invoke ioctl method on
+ * @cmd: ioctl command to execute
+ * @arg: command-specific argument for ioctl
*
* Invokes filesystem specific ->unlocked_ioctl, if one exists; otherwise
* invokes * filesystem specific ->ioctl method. If neither method exists,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix up kerneldoc in fs/ioctl.c a little bit
2008-02-09 7:15 [PATCH] fix up kerneldoc in fs/ioctl.c a little bit Christoph Hellwig
@ 2008-02-09 7:19 ` Erez Zadok
2008-02-09 7:22 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Erez Zadok @ 2008-02-09 7:19 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: akpm, ezk, rdunlap, linux-kernel
In message <20080209071559.GA30903@lst.de>, Christoph Hellwig writes:
> - remove non-standard in/out markers
> - use tabs for formatting
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6/fs/ioctl.c
> ===================================================================
> --- linux-2.6.orig/fs/ioctl.c 2008-02-09 07:49:02.000000000 +0100
> +++ linux-2.6/fs/ioctl.c 2008-02-09 07:49:20.000000000 +0100
> @@ -18,9 +18,9 @@
>
> /**
> * vfs_ioctl - call filesystem specific ioctl methods
> - * @filp: [in] open file to invoke ioctl method on
> - * @cmd: [in] ioctl command to execute
> - * @arg: [in/out] command-specific argument for ioctl
> + * @filp: open file to invoke ioctl method on
> + * @cmd: ioctl command to execute
> + * @arg: command-specific argument for ioctl
> *
> * Invokes filesystem specific ->unlocked_ioctl, if one exists; otherwise
> * invokes * filesystem specific ->ioctl method. If neither method exists,
^
I also think this extra '*' in the last comment line above is spurious,
perhaps the result of a paragraph reformatting command that mixed comment
*'s with text.
Erez.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix up kerneldoc in fs/ioctl.c a little bit
2008-02-09 7:19 ` Erez Zadok
@ 2008-02-09 7:22 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2008-02-09 7:22 UTC (permalink / raw)
To: Erez Zadok; +Cc: Christoph Hellwig, akpm, rdunlap, linux-kernel
On Sat, Feb 09, 2008 at 02:19:27AM -0500, Erez Zadok wrote:
> > * Invokes filesystem specific ->unlocked_ioctl, if one exists; otherwise
> > * invokes * filesystem specific ->ioctl method. If neither method exists,
> ^
>
> I also think this extra '*' in the last comment line above is spurious,
> perhaps the result of a paragraph reformatting command that mixed comment
> *'s with text.
Indeed. Updated patch below:
Index: linux-2.6/fs/ioctl.c
===================================================================
--- linux-2.6.orig/fs/ioctl.c 2008-02-09 07:51:31.000000000 +0100
+++ linux-2.6/fs/ioctl.c 2008-02-09 08:21:30.000000000 +0100
@@ -18,12 +18,12 @@
/**
* vfs_ioctl - call filesystem specific ioctl methods
- * @filp: [in] open file to invoke ioctl method on
- * @cmd: [in] ioctl command to execute
- * @arg: [in/out] command-specific argument for ioctl
+ * @filp: open file to invoke ioctl method on
+ * @cmd: ioctl command to execute
+ * @arg: command-specific argument for ioctl
*
* Invokes filesystem specific ->unlocked_ioctl, if one exists; otherwise
- * invokes * filesystem specific ->ioctl method. If neither method exists,
+ * invokes filesystem specific ->ioctl method. If neither method exists,
* returns -ENOTTY.
*
* Returns 0 on success, -errno on error.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-09 7:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-09 7:15 [PATCH] fix up kerneldoc in fs/ioctl.c a little bit Christoph Hellwig
2008-02-09 7:19 ` Erez Zadok
2008-02-09 7:22 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).