LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Gene Heskett <gene.heskett@gmail.com>
To: Prakash Punnoor <prakash@punnoor.de>
Cc: Andi Kleen <andi@firstfloor.org>,
	mingo@elte.hu, tglx@linutronix.de, lenb@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Replace nvidia timer override quirk with pci id list
Date: Sat, 09 Feb 2008 07:46:25 -0500	[thread overview]
Message-ID: <200802090746.25310.gene.heskett@gmail.com> (raw)
In-Reply-To: <200802081839.18267.prakash@punnoor.de>

On Friday 08 February 2008, Prakash Punnoor wrote:
>On the day of Friday 08 February 2008 Andi Kleen hast written:
>> On Fri, Feb 08, 2008 at 04:13:35PM +0100, Prakash Punnoor wrote:
>> > Sorry, I meant the opposite. I needed the acpi_skip_timer_override
>> > kernel parameter for nforce2, thus no override. So this chipset is
>> > missing here. At least I remember that my nforce2 needed the skipping,
>>
>> I hope you remember correctly and mean it this time. It would be better
>> if you could double check.
>
>Yes, confirmed. timer w/o the skipping stays XT-PIC on nforce2.
>
>w/o skipping:
>
>  0:     153413    XT-PIC-XT        timer
>  1:         10   IO-APIC-edge      i8042
>  8:          2   IO-APIC-edge      rtc
>  9:          0   IO-APIC-fasteoi   acpi
> 12:        112   IO-APIC-edge      i8042
> 14:         37   IO-APIC-edge      ide0
> 16:     165137   IO-APIC-fasteoi   eth0
> 17:          0   IO-APIC-fasteoi   Technisat/B2C2 FlexCop II/IIb/III
> Digital TV PCI Driver
> 18:          0   IO-APIC-fasteoi   NVidia nForce2
> 19:       7922   IO-APIC-fasteoi   nvidia
>NMI:          0
>LOC:     153209
>ERR:          0
>MIS:          0
>
Sort of coming in in the middle of this because I just realized this may have 
something to do with the "exception Emask" errors. I have an NF2, and the 
above 0: type is what I'm getting with, or without, the apparently opposite 
kernel argument, acpi_use_timer_override.  Should I instead be seeing 0: as 
shown below?  If so, what do I change to effect this?  My current .config:

[root@coyote linux-2.6.24]# grep HPET .config
CONFIG_HPET_TIMER=y
CONFIG_HPET_EMULATE_RTC=y
CONFIG_HPET=y
# CONFIG_HPET_RTC_IRQ is not set
# CONFIG_HPET_MMAP is not set

Thanks.

>w/ skipping:
>           CPU0
>  0:      47834   IO-APIC-edge      timer
>  1:         10   IO-APIC-edge      i8042
>  8:          2   IO-APIC-edge      rtc
>  9:          0   IO-APIC-fasteoi   acpi
> 12:        112   IO-APIC-edge      i8042
> 14:         37   IO-APIC-edge      ide0
> 16:     152413   IO-APIC-fasteoi   eth0
> 17:          0   IO-APIC-fasteoi   Technisat/B2C2 FlexCop II/IIb/III
> Digital TV PCI Driver
> 18:          0   IO-APIC-fasteoi   NVidia nForce2
> 19:       1582   IO-APIC-fasteoi   nvidia
>NMI:          0
>LOC:      47736
>ERR:          0
>MIS:          0
>
>
>lspci -n:
>00:00.0 0600: 10de:01e0 (rev c1)
>00:00.1 0500: 10de:01eb (rev c1)
>00:00.2 0500: 10de:01ee (rev c1)
>00:00.3 0500: 10de:01ed (rev c1)
>00:00.4 0500: 10de:01ec (rev c1)
>00:00.5 0500: 10de:01ef (rev c1)
>00:01.0 0601: 10de:0060 (rev a3)
>00:01.1 0c05: 10de:0064 (rev a2)
>00:02.0 0c03: 10de:0067 (rev a3)
>00:02.1 0c03: 10de:0067 (rev a3)
>00:02.2 0c03: 10de:0068 (rev a3)
>00:04.0 0200: 10de:0066 (rev a1)
>00:05.0 0401: 10de:006b (rev a2)
>00:06.0 0401: 10de:006a (rev a1)
>00:08.0 0604: 10de:006c (rev a3)
>00:09.0 0101: 10de:0065 (rev a2)
>00:0d.0 0c00: 10de:006e (rev a3)
>00:1e.0 0604: 10de:01e8 (rev c1)
>01:08.0 0280: 13d0:2103 (rev 01)
>02:00.0 0300: 10de:0281 (rev a1)
>
>> I'm a little sceptical because we had this patch in OpenSUSE 10.3
>> and I didn't think there were complaints from NF2 users.
>> With the changes you're requesting it turns from something
>> very well tested into something experimental.
>
>Well, even w/o the skipping my nforce2 system wasn't unstable, AFAIK. So I
>don't think just because of the XT-PIC entry people would complain.
>
>See why I don't want the quirk to be applied more than needed? *NOT*
> applying the quirk on nforce2 didn't cause any obvious side effects.
> APPLYING to mcp51 causes hard lock-ups.
>
>> But NF2 should not need a timer override anyways so probably
>> ignoring it there is ok.
>>
>> Actually checking CK804 is already an Nforce2, but you might
>> have NF2S which has a different ID. Do you have full lspci/lspci -n
>> output?
>
>My nforce2 board has different id then the listed ones, so that one needs to
>be included.
>
>> Ok I'm appending another patch that adds the NF2S too, can
>> you please test it on that machine?
>
>No point if the quirk doesn't get triggered.
>
>> > > I'm appending a revised patch. Does it work for you?
>> >
>> > I haven't tested it, but it would "work" as it would bail out in my case
>>
>> Can you please test it?
>
>Will try the final version...
>
>> > or not. Are you actually sure that so many nforceX boards have broken
>> > bioses?
>>
>> Yes, it was a problem in the Nvidia reference BIOS that they sent to OEMs
>> to base their own BIOS on, so pretty much everybody had this problem.
>>
>> We went over this with Nvidia engineers with a fine comb at this
>> point. If you search the mailing list archives you might even
>> find the discussions.
>
>Yes, I actually linked to that discussion in the previous mail and there
> Allen Martin only stated that nforce2 and 3 may be affected. So I wonder
> why you (or Len) include nforce4 and mcp51 and so on?
>
>Can't the quirk be made more intelligent? Ie. if we want APIC mode and timer
>stays as XT-PIC, then and only then rewire the timer and don't use the
>override, ie apply quirk? If rewiring isn't possible, then the kernel should
>als least print out a big fat warning that the user should probably skip the
>override. I don't know enough on the subject to explain it more precisely.
>
>bye,


-- 
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
You are in a maze of little twisting passages, all alike.

  parent reply	other threads:[~2008-02-09 12:46 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07 19:55 Andi Kleen
2008-02-07 21:21 ` Prakash Punnoor
2008-02-08 11:36   ` Andi Kleen
2008-02-08 15:13     ` Prakash Punnoor
2008-02-08 15:18       ` Prakash Punnoor
2008-02-08 16:09       ` Andi Kleen
2008-02-08 17:39         ` Prakash Punnoor
2008-02-08 19:01           ` Andi Kleen
2008-02-08 19:00             ` Prakash Punnoor
2008-02-08 21:02               ` Andi Kleen
2008-02-08 23:08                 ` Prakash Punnoor
2008-02-09 11:06                   ` Thomas Gleixner
2008-02-09 12:18                     ` Prakash Punnoor
2008-02-09 11:59                   ` Andi Kleen
2008-02-09 11:53                     ` Prakash Punnoor
2008-02-09 14:31                       ` Andi Kleen
2008-02-09 15:51                         ` Prakash Punnoor
2008-02-09 16:56                           ` Andi Kleen
2008-02-09 17:30                             ` Prakash Punnoor
2008-02-09 12:17                   ` [PATCH] Replace nvidia timer override quirk with pci id list II Andi Kleen
2010-01-29  8:32               ` [PATCH] Replace nvidia timer override quirk with pci id list Yuhong Bao
2008-02-09 12:46           ` Gene Heskett [this message]
2008-02-09 14:18             ` Andi Kleen
2008-02-09 14:03               ` Alan Cox
2008-02-09 18:02               ` Gene Heskett
2008-02-09 18:11                 ` Prakash Punnoor
2008-02-09 20:05                   ` Gene Heskett
2008-02-09 21:13                     ` Prakash Punnoor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802090746.25310.gene.heskett@gmail.com \
    --to=gene.heskett@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=prakash@punnoor.de \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] Replace nvidia timer override quirk with pci id list' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).