LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: CONFIG_HIGHPTE vs. sub-page page tables.
Date: Sat, 9 Feb 2008 11:37:28 +0100	[thread overview]
Message-ID: <20080209103728.GA29375@elte.hu> (raw)
In-Reply-To: <1202551589.8936.1.camel@localhost>


* Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:

> On Sat, 2008-02-09 at 00:15 +0100, Ingo Molnar wrote:
> > > config attached. It seems all !PAE 32-bit kernel builds are broken due 
> > > to this. The patch below fixes it.
> > 
> > ok, the patch was against x86.git which had some other changes in 
> > this area - the one below applies to vanilla -git and fixes the bug.
> 
> Thanks Ingo for taking care of it. I already feared that we'll have 
> some more fallout from this patch although it has been in -mm for 
> quite a while. The real testing starts after a patch hit Linus tree.

i think the worst is over already and i'm reasonably sure that there are 
no more bugs in it - this _is_ a 1:1 patch after all, so in theory the 
worst side-effect should be build breakages due to include file 
spaghetti. The window for this particular breakage was just 256 commits, 
that's OK i think.

If you want less stress next time around you might want to consider 
pushing such patches via individual architectures, so that it can all be 
shaken out (and such build bugs are found quickly) and pushed via the 
architecture trees. (Even such a patch that changes the number of 
cross-arch function arguments and introduces a new type can be 
architectured in a way to make it per arch.)

	Ingo

  reply	other threads:[~2008-02-09 10:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200802081902.m18J2nOm005840@hera.kernel.org>
2008-02-08 23:04 ` Ingo Molnar
2008-02-08 23:15   ` Ingo Molnar
2008-02-09 10:06     ` Martin Schwidefsky
2008-02-09 10:37       ` Ingo Molnar [this message]
2008-02-09 10:56         ` Martin Schwidefsky
2008-02-09 17:56           ` Mike Frysinger
2008-02-10  9:17             ` Martin Schwidefsky
2008-02-10  9:25               ` Mike Frysinger
2008-02-10  9:41                 ` Martin Schwidefsky
2008-02-10 10:06                   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080209103728.GA29375@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: CONFIG_HIGHPTE vs. sub-page page tables.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).