LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <ak@suse.de>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] [1/2] Use standard global TLB flushes in MTRR code v2
Date: Sat, 9 Feb 2008 12:16:12 +0100	[thread overview]
Message-ID: <20080209111612.GA5273@elte.hu> (raw)
In-Reply-To: <20080208122.996401758@suse.de>


* Andi Kleen <ak@suse.de> wrote:

> This is more idiomatic and it does not really make sense for this code 
> to implement a own TLB flushing variant.
> 
> The control registers will be read/written a few times more, but that 
> should not really matter for this code.

what you do not point out in the changelog, and what i've mentioned to 
you in past replies but you still ignore it: that the patch changes what 
the code does - we now keep PGE enabled in cr4 during the MTRR changing.

the MTRR code is historically fragile, rarely triggered code, laced with 
CPU errata. The change brings us absolutely nothing (it in fact 
increases the code size a bit) and it is just not worth the risk at this 
stage.

	Ingo

      parent reply	other threads:[~2008-02-09 11:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 12:22 Andi Kleen
2008-02-08 12:22 ` [PATCH] [2/2] Fix and simplify k8.c Kconfig dependencies Andi Kleen
2008-02-09 11:16 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080209111612.GA5273@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] [1/2] Use standard global TLB flushes in MTRR code v2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).