LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: tglx@linutronix.de, mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: [PATCH] [3/5] Add warning when RTC clock reports binary
Date: Sat,  9 Feb 2008 16:16:59 +0100 (CET)	[thread overview]
Message-ID: <20080209151659.4F0EA1B41D1@basil.firstfloor.org> (raw)
In-Reply-To: <20080209416.271135970@suse.de>


We tend to assume the RTC clock is BCD, so print a warning
if it claims to be binary.

Signed-off-by: Andi Kleen <ak@suse.de>

Index: linux/arch/x86/kernel/rtc.c
===================================================================
--- linux.orig/arch/x86/kernel/rtc.c
+++ linux/arch/x86/kernel/rtc.c
@@ -94,6 +94,8 @@ int mach_set_rtc_mmss(unsigned long nowt
 
 unsigned long mach_get_cmos_time(void)
 {
+	unsigned status;
+	static int warned;
 	unsigned int year, mon, day, hour, min, sec, century = 0;
 
 	/*
@@ -119,7 +121,13 @@ unsigned long mach_get_cmos_time(void)
 		century = CMOS_READ(acpi_gbl_FADT.century);
 #endif
 
-	if (RTC_ALWAYS_BCD || !(CMOS_READ(RTC_CONTROL) & RTC_DM_BINARY)) {
+	status = CMOS_READ(RTC_CONTROL);
+	if (RTC_ALWAYS_BCD && (status & RTC_DM_BINARY) && !warned) {
+		printk(KERN_INFO "RTC clock reports binary. Ignored\n");
+		warned = 1;
+	}
+
+	if (RTC_ALWAYS_BCD || !(status & RTC_DM_BINARY)) {
 		BCD_TO_BIN(sec);
 		BCD_TO_BIN(min);
 		BCD_TO_BIN(hour);

  parent reply	other threads:[~2008-02-09 15:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-09 15:16 [PATCH] [1/5] Only do century BCD conversion when we know the RTC is BCD Andi Kleen
2008-02-09 15:16 ` [PATCH] [2/5] Use 2000 offset for 32bit kernels Andi Kleen
2008-02-16 19:24   ` Thomas Gleixner
2008-02-20 10:07     ` Thomas Gleixner
2008-02-20 10:23       ` Andi Kleen
2008-02-09 15:16 ` Andi Kleen [this message]
2008-02-16 19:38   ` [PATCH] [3/5] Add warning when RTC clock reports binary Thomas Gleixner
2008-02-09 15:17 ` [PATCH] [4/5] Fix wrong comment Andi Kleen
2008-02-09 15:17 ` [PATCH] [5/5] Enable ACPI extended century handling for 32bit too v2 Andi Kleen
2008-02-16 19:38   ` Thomas Gleixner
2008-02-11  8:30 ` [PATCH] [1/5] Only do century BCD conversion when we know the RTC is BCD Thomas Gleixner
2008-02-11  8:56   ` Andi Kleen
2008-02-11 22:08     ` Thomas Gleixner
2008-02-11 22:15       ` Andi Kleen
2008-02-12 20:36         ` Thomas Gleixner
2008-02-13 13:49           ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080209151659.4F0EA1B41D1@basil.firstfloor.org \
    --to=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] [3/5] Add warning when RTC clock reports binary' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).