Two comments on menuconfig usability

Two comments on menuconfig usability

[Michael Büker]

Hi all, [please to CC me]

There's two things I want to comment on regarding menuconfig:

1) I know of the purpose of oldconfig, but I prefer using menuconfig for 
upgrading to newer kernel versions, because most of the time, I would select 
the standard options for new features anyway. menuconfig has the "(NEW)" 
string at the end of a feature's description. However, I find that hard to 
see among all the names of various lenghts. My proposal would be to have 
an "N" or a "NEW" appear to the _left_ of the selection boxes, so that, 
browsing through the menus, one could more easily spot the interesting 
places.

2) When selecting "Ralink driver support" (CONFIG_RT2X00), the accompanying 
drivers (CONFIG_RT2400PCI, CONFIG_RT61PC, ...) appear unindented. They should 
be indented by four spaces.

Cheers!
~Mik

-- 
Intrinsically unobtrusive antidisestablishmentarianistic
inclinations cause considerable psychotic devastation
among exasperated and marginally discomposed ornithologists.

[PATCH] wireless: rt2x00: fix driver menu indenting

[Randy Dunlap]

On Sat, 9 Feb 2008 16:23:06 +0100 Michael Büker wrote:

> 2) When selecting "Ralink driver support" (CONFIG_RT2X00), the accompanying 
> drivers (CONFIG_RT2400PCI, CONFIG_RT61PC, ...) appear unindented. They should 
> be indented by four spaces.

Yes, patch is below.

---
From: Randy Dunlap <randy.dunlap@oracle.com>

Michael Büker <m.bueker@berlin.de> reports that the RT2x00 drivers
are not indented as they should be, so use proper dependencies to make
them be indented as expected.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/net/wireless/rt2x00/Kconfig |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

--- linux-2.6.24-git21.orig/drivers/net/wireless/rt2x00/Kconfig
+++ linux-2.6.24-git21/drivers/net/wireless/rt2x00/Kconfig
@@ -11,18 +11,17 @@ config RT2X00
 	  will also be created. That library (when the driver is built as
 	  a module) will be called "rt2x00lib.ko".
 
+if RT2X00
+
 config RT2X00_LIB
 	tristate
-	depends on RT2X00
 
 config RT2X00_LIB_PCI
 	tristate
-	depends on RT2X00
 	select RT2X00_LIB
 
 config RT2X00_LIB_USB
 	tristate
-	depends on RT2X00
 	select RT2X00_LIB
 
 config RT2X00_LIB_FIRMWARE
@@ -39,7 +38,7 @@ config RT2X00_LIB_RFKILL
 
 config RT2400PCI
 	tristate "Ralink rt2400 pci/pcmcia support"
-	depends on RT2X00 && PCI
+	depends on PCI
 	select RT2X00_LIB_PCI
 	select EEPROM_93CX6
 	---help---
@@ -58,7 +57,7 @@ config RT2400PCI_RFKILL
 
 config RT2500PCI
 	tristate "Ralink rt2500 pci/pcmcia support"
-	depends on RT2X00 && PCI
+	depends on PCI
 	select RT2X00_LIB_PCI
 	select EEPROM_93CX6
 	---help---
@@ -77,7 +76,7 @@ config RT2500PCI_RFKILL
 
 config RT61PCI
 	tristate "Ralink rt61 pci/pcmcia support"
-	depends on RT2X00 && PCI
+	depends on PCI
 	select RT2X00_LIB_PCI
 	select RT2X00_LIB_FIRMWARE
 	select EEPROM_93CX6
@@ -97,7 +96,7 @@ config RT61PCI_RFKILL
 
 config RT2500USB
 	tristate "Ralink rt2500 usb support"
-	depends on RT2X00 && USB
+	depends on USB
 	select RT2X00_LIB_USB
 	---help---
 	  This is an experimental driver for the Ralink rt2500 wireless chip.
@@ -106,7 +105,7 @@ config RT2500USB
 
 config RT73USB
 	tristate "Ralink rt73 usb support"
-	depends on RT2X00 && USB
+	depends on USB
 	select RT2X00_LIB_USB
 	select RT2X00_LIB_FIRMWARE
 	---help---
@@ -128,3 +127,4 @@ config RT2X00_DEBUG
 	---help---
 	  Enable debugging output for all rt2x00 modules
 
+endif

Re: [Rt2400-devel] [PATCH] wireless: rt2x00: fix driver menu indenting

[Ivo van Doorn]

On Sunday 10 February 2008, Randy Dunlap wrote:
> On Sat, 9 Feb 2008 16:23:06 +0100 Michael Büker wrote:
> 
> > 2) When selecting "Ralink driver support" (CONFIG_RT2X00), the accompanying 
> > drivers (CONFIG_RT2400PCI, CONFIG_RT61PC, ...) appear unindented. They should 
> > be indented by four spaces.
> 
> Yes, patch is below.
> 
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Michael Büker <m.bueker@berlin.de> reports that the RT2x00 drivers
> are not indented as they should be, so use proper dependencies to make
> them be indented as expected.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Ack-by: Ivo van Doorn <IvDoorn@gmail.com>

---
John,
Could you push this directly into wireless-2.6 and probably upstream as well.

Thanks.

Ivo

> ---
>  drivers/net/wireless/rt2x00/Kconfig |   16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> --- linux-2.6.24-git21.orig/drivers/net/wireless/rt2x00/Kconfig
> +++ linux-2.6.24-git21/drivers/net/wireless/rt2x00/Kconfig
> @@ -11,18 +11,17 @@ config RT2X00
>  	  will also be created. That library (when the driver is built as
>  	  a module) will be called "rt2x00lib.ko".
>  
> +if RT2X00
> +
>  config RT2X00_LIB
>  	tristate
> -	depends on RT2X00
>  
>  config RT2X00_LIB_PCI
>  	tristate
> -	depends on RT2X00
>  	select RT2X00_LIB
>  
>  config RT2X00_LIB_USB
>  	tristate
> -	depends on RT2X00
>  	select RT2X00_LIB
>  
>  config RT2X00_LIB_FIRMWARE
> @@ -39,7 +38,7 @@ config RT2X00_LIB_RFKILL
>  
>  config RT2400PCI
>  	tristate "Ralink rt2400 pci/pcmcia support"
> -	depends on RT2X00 && PCI
> +	depends on PCI
>  	select RT2X00_LIB_PCI
>  	select EEPROM_93CX6
>  	---help---
> @@ -58,7 +57,7 @@ config RT2400PCI_RFKILL
>  
>  config RT2500PCI
>  	tristate "Ralink rt2500 pci/pcmcia support"
> -	depends on RT2X00 && PCI
> +	depends on PCI
>  	select RT2X00_LIB_PCI
>  	select EEPROM_93CX6
>  	---help---
> @@ -77,7 +76,7 @@ config RT2500PCI_RFKILL
>  
>  config RT61PCI
>  	tristate "Ralink rt61 pci/pcmcia support"
> -	depends on RT2X00 && PCI
> +	depends on PCI
>  	select RT2X00_LIB_PCI
>  	select RT2X00_LIB_FIRMWARE
>  	select EEPROM_93CX6
> @@ -97,7 +96,7 @@ config RT61PCI_RFKILL
>  
>  config RT2500USB
>  	tristate "Ralink rt2500 usb support"
> -	depends on RT2X00 && USB
> +	depends on USB
>  	select RT2X00_LIB_USB
>  	---help---
>  	  This is an experimental driver for the Ralink rt2500 wireless chip.
> @@ -106,7 +105,7 @@ config RT2500USB
>  
>  config RT73USB
>  	tristate "Ralink rt73 usb support"
> -	depends on RT2X00 && USB
> +	depends on USB
>  	select RT2X00_LIB_USB
>  	select RT2X00_LIB_FIRMWARE
>  	---help---
> @@ -128,3 +127,4 @@ config RT2X00_DEBUG
>  	---help---
>  	  Enable debugging output for all rt2x00 modules
>  
> +endif
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rt2400-devel mailing list
> Rt2400-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/rt2400-devel
> 

Re: [Rt2400-devel] [PATCH] wireless: rt2x00: fix driver menu indenting

[Randy Dunlap]

On Sun, 10 Feb 2008 20:03:25 +0100 Ivo van Doorn wrote:

> On Sunday 10 February 2008, Randy Dunlap wrote:
> > On Sat, 9 Feb 2008 16:23:06 +0100 Michael Büker wrote:
> > 
> > > 2) When selecting "Ralink driver support" (CONFIG_RT2X00), the accompanying 
> > > drivers (CONFIG_RT2400PCI, CONFIG_RT61PC, ...) appear unindented. They should 
> > > be indented by four spaces.
> > 
> > Yes, patch is below.
> > 
> > ---
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > Michael Büker <m.bueker@berlin.de> reports that the RT2x00 drivers
> > are not indented as they should be, so use proper dependencies to make
> > them be indented as expected.
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Ack-by: Ivo van Doorn <IvDoorn@gmail.com>
> 
> ---
> John,
> Could you push this directly into wireless-2.6 and probably upstream as well.
> 
> Thanks.
> 
> Ivo

John, do you have this patch queued somewhere?


> > ---
> >  drivers/net/wireless/rt2x00/Kconfig |   16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> > 
> > --- linux-2.6.24-git21.orig/drivers/net/wireless/rt2x00/Kconfig
> > +++ linux-2.6.24-git21/drivers/net/wireless/rt2x00/Kconfig
> > @@ -11,18 +11,17 @@ config RT2X00
> >  	  will also be created. That library (when the driver is built as
> >  	  a module) will be called "rt2x00lib.ko".
> >  
> > +if RT2X00
> > +
> >  config RT2X00_LIB
> >  	tristate
> > -	depends on RT2X00
> >  
> >  config RT2X00_LIB_PCI
> >  	tristate
> > -	depends on RT2X00
> >  	select RT2X00_LIB
> >  
> >  config RT2X00_LIB_USB
> >  	tristate
> > -	depends on RT2X00
> >  	select RT2X00_LIB
> >  
> >  config RT2X00_LIB_FIRMWARE
> > @@ -39,7 +38,7 @@ config RT2X00_LIB_RFKILL
> >  
> >  config RT2400PCI
> >  	tristate "Ralink rt2400 pci/pcmcia support"
> > -	depends on RT2X00 && PCI
> > +	depends on PCI
> >  	select RT2X00_LIB_PCI
> >  	select EEPROM_93CX6
> >  	---help---
> > @@ -58,7 +57,7 @@ config RT2400PCI_RFKILL
> >  
> >  config RT2500PCI
> >  	tristate "Ralink rt2500 pci/pcmcia support"
> > -	depends on RT2X00 && PCI
> > +	depends on PCI
> >  	select RT2X00_LIB_PCI
> >  	select EEPROM_93CX6
> >  	---help---
> > @@ -77,7 +76,7 @@ config RT2500PCI_RFKILL
> >  
> >  config RT61PCI
> >  	tristate "Ralink rt61 pci/pcmcia support"
> > -	depends on RT2X00 && PCI
> > +	depends on PCI
> >  	select RT2X00_LIB_PCI
> >  	select RT2X00_LIB_FIRMWARE
> >  	select EEPROM_93CX6
> > @@ -97,7 +96,7 @@ config RT61PCI_RFKILL
> >  
> >  config RT2500USB
> >  	tristate "Ralink rt2500 usb support"
> > -	depends on RT2X00 && USB
> > +	depends on USB
> >  	select RT2X00_LIB_USB
> >  	---help---
> >  	  This is an experimental driver for the Ralink rt2500 wireless chip.
> > @@ -106,7 +105,7 @@ config RT2500USB
> >  
> >  config RT73USB
> >  	tristate "Ralink rt73 usb support"
> > -	depends on RT2X00 && USB
> > +	depends on USB
> >  	select RT2X00_LIB_USB
> >  	select RT2X00_LIB_FIRMWARE
> >  	---help---
> > @@ -128,3 +127,4 @@ config RT2X00_DEBUG
> >  	---help---
> >  	  Enable debugging output for all rt2x00 modules
> >  
> > +endif


---
~Randy

Re: [Rt2400-devel] [PATCH] wireless: rt2x00: fix driver menu indenting

[John W. Linville]

On Tue, Mar 04, 2008 at 10:00:29PM -0800, Randy Dunlap wrote:
> On Sun, 10 Feb 2008 20:03:25 +0100 Ivo van Doorn wrote:
> 
> > On Sunday 10 February 2008, Randy Dunlap wrote:
> > > On Sat, 9 Feb 2008 16:23:06 +0100 Michael Büker wrote:
> > > 
> > > > 2) When selecting "Ralink driver support" (CONFIG_RT2X00), the accompanying 
> > > > drivers (CONFIG_RT2400PCI, CONFIG_RT61PC, ...) appear unindented. They should 
> > > > be indented by four spaces.
> > > 
> > > Yes, patch is below.
> > > 
> > > ---
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > 
> > > Michael Büker <m.bueker@berlin.de> reports that the RT2x00 drivers
> > > are not indented as they should be, so use proper dependencies to make
> > > them be indented as expected.
> > > 
> > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > Ack-by: Ivo van Doorn <IvDoorn@gmail.com>
> > 
> > ---
> > John,
> > Could you push this directly into wireless-2.6 and probably upstream as well.
> > 
> > Thanks.
> > 
> > Ivo
> 
> John, do you have this patch queued somewhere?

It is in net-2.6.26.

commit 0d84d78db5bad848e385cbb1e4ae2ea1f5f27641
Author: Randy Dunlap <randy.dunlap@oracle.com>
Date:   Sun Feb 10 10:52:52 2008 -0800

    wireless: rt2x00: fix driver menu indenting

    Michael Büker <m.bueker@berlin.de> reports that the RT2x00 drivers
    are not indented as they should be, so use proper dependencies to make
    them be indented as expected.

    Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
    Ack-by: Ivo van Doorn <IvDoorn@gmail.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

Hth!

John
-- 
John W. Linville
linville@tuxdriver.com