LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* some questions about generated headers
@ 2008-02-09 19:07 Robert P. J. Day
  2008-02-09 19:48 ` Bartlomiej Zolnierkiewicz
  0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2008-02-09 19:07 UTC (permalink / raw)
  To: Linux Kernel Mailing List


  just a few observations about the generated headers and whether
there's some cleanup to be done there.

1)

  the generated header linux/tty.h consists solely of:

=====
#ifndef _LINUX_TTY_H
#define _LINUX_TTY_H

/*
 * 'tty.h' defines some structures used by tty_io.c and some defines.
 */

#endif
=====

  i once submitted a patch that, if this header were included from
userspace, would print, "Don't include me from user space, I'm empty."
or something to that effect.  is that worth doing?  or should user
space code be including that header at all?  (should an empty header
even be *exported* to user space?)

2)

  include/linux/soundcard.h still contains some weird, non-standard
checks:

...
#if (!defined(__KERNEL__) && !defined(KERNEL) && !defined(INKERNEL) &&
!defined(_KERNEL)) || defined(USE_SEQ_MACROS)
...

  so what's with KERNEL or INKERNEL or _KERNEL?  do those tests still
have any value?  or can they be tossed?

3)

  related to 2), what's up with __KERNEL as well?  it still shows up
in a number of places in the kernel source.   for example, see
include/linux/hdsmart.h:

...
#ifndef __KERNEL
...
#endif /* __KERNEL__ *

(and that missing trailing slash creeps me out, too.)

4)

  any chance of replacing the current unifdef with sunifdef (son of
unifdef), which is smarter and can simplify some of the compound
logical preprocessor checks to get rid of more junk in those generated
headers?

  http://www.sunifdef.strudl.org/


  that should do for now.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

Home page:                                         http://crashcourse.ca
Fedora Cookbook:    http://crashcourse.ca/wiki/index.php/Fedora_Cookbook
========================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: some questions about generated headers
  2008-02-09 19:07 some questions about generated headers Robert P. J. Day
@ 2008-02-09 19:48 ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2008-02-09 19:48 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: Linux Kernel Mailing List

On Saturday 09 February 2008, Robert P. J. Day wrote:

[...]

>> 3)
> 
>   related to 2), what's up with __KERNEL as well?  it still shows up
> in a number of places in the kernel source.   for example, see
> include/linux/hdsmart.h:
> 
> ...
> #ifndef __KERNEL
> ...
> #endif /* __KERNEL__ *
> 
> (and that missing trailing slash creeps me out, too.)

These hdsmart.h goofups are my doings. 8)

[ I must have been half-asleep while making these changes but no harm
  for kernel side was done (this file is not used by kernel anymore)
  and yes, I didn't have motivation to look up for answer to 3) so I've
  just put fdefs there. ]

Thanks,
Bart

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-09 19:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-09 19:07 some questions about generated headers Robert P. J. Day
2008-02-09 19:48 ` Bartlomiej Zolnierkiewicz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).