LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4
Date: Sun, 10 Feb 2008 00:18:55 -0500 [thread overview]
Message-ID: <20080210051855.GA22064@infradead.org> (raw)
In-Reply-To: <200802100110.09301.linux@rainbow-software.org>
On Sun, Feb 10, 2008 at 01:10:07AM +0100, Ondrej Zary wrote:
> > > +typedef enum { EL3_ISA, EL3_PNP, EL3_MCA, EL3_EISA } el3_cardtype;
> > > +
> >
> > No typedef please (see checkpatch)
>
> Is there any standard way to solve this without a typedef? I added
> el3_dev_fill() function which fills that card type value according to a
> parameter passed to it. "int" could be used instead and "#define EL3_ISA
> 0", "#define EL3_PNP 1" - but I think that's ugly.
enum el3_cardtype {
EL3_ISA,
EL3_PNP,
EL3_MCA,
EL3_EISA,
};
> > > struct el3_private {
> > > struct net_device_stats stats;
> >
> > Use network device stats in net_device now
>
> OK, looks like the driver will need some more patches.
While I agree with Stephens comment that this driver should be using
the stats in net_device that's totally out of scope for this patch.
As you're the defacto maintainer of this driver now it would be nice
if you could submit another one for it.
> > > - struct net_device *next_dev;
> > > spinlock_t lock;
> > > /* skb send-queue */
> > > int head, size;
> > > struct sk_buff *queue[SKB_QUEUE_SIZE];
> >
> > What about sk_buff_head (linked list instead)?
>
> I don't know anything about this, maybe in next patch.
Yes, separate patch please.
next prev parent reply other threads:[~2008-02-10 5:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-31 19:12 [PATCH] [RFC] 3c509: convert to isa_driver and pnp_driver Ondrej Zary
2008-02-02 18:25 ` [PATCH] [RFC] 3c509: convert to isa_driver and pnp_driver v2 Ondrej Zary
2008-02-02 20:50 ` Jeff Garzik
2008-02-02 21:08 ` Ondrej Zary
2008-02-04 23:02 ` [PATCH] [RFC] 3c509: convert to isa_driver and pnp_driver v3 Ondrej Zary
2008-02-06 18:09 ` [PATCH] [resend] " Ondrej Zary
2008-02-07 11:51 ` Marc Zyngier
2008-02-07 17:31 ` [PATCH] 3c509: convert to isa_driver and pnp_driver v4 Ondrej Zary
2008-02-09 21:33 ` [PATCH] [resend] " Ondrej Zary
2008-02-09 21:48 ` Stephen Hemminger
2008-02-10 0:10 ` Ondrej Zary
2008-02-10 5:18 ` Christoph Hellwig [this message]
2008-02-10 21:03 ` [PATCH] 3c509: convert to isa_driver and pnp_driver v5 Ondrej Zary
2008-02-13 21:28 ` [PATCH] [resend] " Ondrej Zary
2008-02-17 11:02 ` Ondrej Zary
2008-03-04 4:25 ` Andrew Morton
2008-02-02 21:07 ` [PATCH] [RFC] 3c509: convert to isa_driver and pnp_driver v2 Pekka Enberg
2008-02-02 21:28 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080210051855.GA22064@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--subject='Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).