LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [1/6] pids: add pid_max prototype
@ 2008-02-10  7:13 Ingo Molnar
  2008-02-10  7:34 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Ingo Molnar @ 2008-02-10  7:13 UTC (permalink / raw)
  To: linux-kernel; +Cc: Linus Torvalds, Andrew Morton, Thomas Gleixner, Jason Wessel

From: Ingo Molnar <mingo@elte.hu>

add pid_max prototype - used by sysctl and will be used by kgdb as well.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 include/linux/pid.h |    2 ++
 kernel/sysctl.c     |    2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

Index: linux-kgdb.q/include/linux/pid.h
===================================================================
--- linux-kgdb.q.orig/include/linux/pid.h
+++ linux-kgdb.q/include/linux/pid.h
@@ -86,6 +86,8 @@ extern struct task_struct *FASTCALL(get_
 
 extern struct pid *get_task_pid(struct task_struct *task, enum pid_type type);
 
+extern int pid_max;
+
 /*
  * attach_pid() and detach_pid() must be called with the tasklist_lock
  * write-held.
Index: linux-kgdb.q/kernel/sysctl.c
===================================================================
--- linux-kgdb.q.orig/kernel/sysctl.c
+++ linux-kgdb.q/kernel/sysctl.c
@@ -32,6 +32,7 @@
 #include <linux/init.h>
 #include <linux/kernel.h>
 #include <linux/kobject.h>
+#include <linux/pid.h>
 #include <linux/net.h>
 #include <linux/sysrq.h>
 #include <linux/highuid.h>
@@ -71,7 +72,6 @@ extern int max_threads;
 extern int core_uses_pid;
 extern int suid_dumpable;
 extern char core_pattern[];
-extern int pid_max;
 extern int min_free_kbytes;
 extern int pid_max_min, pid_max_max;
 extern int sysctl_drop_caches;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [1/6] pids: add pid_max prototype
  2008-02-10  7:13 [1/6] pids: add pid_max prototype Ingo Molnar
@ 2008-02-10  7:34 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2008-02-10  7:34 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: linux-kernel, Linus Torvalds, Andrew Morton, Thomas Gleixner,
	Jason Wessel

On Sun, Feb 10, 2008 at 08:13:21AM +0100, Ingo Molnar wrote:
> From: Ingo Molnar <mingo@elte.hu>
> 
> add pid_max prototype - used by sysctl and will be used by kgdb as well.

Looks good, and this should go in ASAP independent of kgdb.

And while you're at it, I think all of the below want to find a suitable
place in a header somewhere:

> @@ -71,7 +72,6 @@ extern int max_threads;
>  extern int core_uses_pid;
>  extern int suid_dumpable;
>  extern char core_pattern[];
> -extern int pid_max;
>  extern int min_free_kbytes;
>  extern int pid_max_min, pid_max_max;
>  extern int sysctl_drop_caches;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-10  7:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-10  7:13 [1/6] pids: add pid_max prototype Ingo Molnar
2008-02-10  7:34 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).