LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Maximilian Wilhelm <max@rfc2324.org>
To: Krzysztof Oledzki <olel@ans.pl>
Cc: Maximilian Wilhelm <max@rfc2324.org>,
	linux-kernel@vger.kernel.org, Eric.Moore@lsi.com
Subject: Re: Kernel Panic in MPT SAS on 2.6.24 (and 2.6.23.14, 2.6.23.9)
Date: Sun, 10 Feb 2008 18:48:08 +0100	[thread overview]
Message-ID: <20080210174807.GB20450@outback.rfc2324.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0802101823020.22894@bizon.gios.gov.pl>

Am Sunday, den 10 February hub Krzysztof Oledzki folgendes in die Tasten:

> >I did a git bisect between v2.6.22 v2.6.23 and it seems that
> > 6cb8f91320d3e720351c21741da795fed580b21b
> >introduced some badness.

> Thanks! This was *really* useful!

> Now, how about attached patch? Should work with both 2.6.23 and 2.6.24.

I build a patched 2.6.24 and it bootet without a problem.

> [SCSI] mpt fusion: Don't oops if NumPhys==0

> Don't oops if NumPhys==0, instead return -ENODEV.
> This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=9909
 
> Signed-off-by: Krzysztof Piotr Oledzki <ole@ans.pl>
Tested-by: Maximilian Wilhelm <max@rfc2324.org>

> diff -Nur a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
> --- a/drivers/message/fusion/mptsas.c	2007-10-09 22:31:38.000000000 +0200
> +++ b/drivers/message/fusion/mptsas.c	2008-02-10 17:38:51.000000000 +0100
> @@ -1772,6 +1772,11 @@
>  	if (error)
>  		goto out_free_consistent;
>  
> +	if (!buffer->NumPhys) {
> +		error = -ENODEV;
> +		goto out_free_consistent;
> +	}
> +
>  	/* save config data */
>  	port_info->num_phys = buffer->NumPhys;
>  	port_info->phy_info = kcalloc(port_info->num_phys,

Many Thanks!

Ciao
Max
-- 
	Follow the white penguin.

      reply	other threads:[~2008-02-10 17:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-06 21:04 Maximilian Wilhelm
2008-02-06 22:52 ` Andrew Morton
2008-02-07 22:14 ` Krzysztof Oledzki
2008-02-08  1:20   ` Maximilian Wilhelm
2008-02-08  1:48     ` Maximilian Wilhelm
2008-02-10  2:46       ` Maximilian Wilhelm
2008-02-10 17:25         ` Krzysztof Oledzki
2008-02-10 17:48           ` Maximilian Wilhelm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080210174807.GB20450@outback.rfc2324.org \
    --to=max@rfc2324.org \
    --cc=Eric.Moore@lsi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olel@ans.pl \
    --subject='Re: Kernel Panic in MPT SAS on 2.6.24 (and 2.6.23.14, 2.6.23.9)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).