LKML Archive on
help / color / mirror / Atom feed
From: Daniel Phillips <>
To: Pekka J Enberg <>
Subject: [PATCH] vmsplice exploit fix (was: splice: fix user pointer access in get_iovec_page_array)
Date: Sun, 10 Feb 2008 23:29:50 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <Pine.LNX.4.64.0802101644510.12440@sbz-30.cs.Helsinki.FI>

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

Kudos to all involved in the rapid response.  But.

Information on patching this vulnerability is not available front and 
center in many of the places you would expect: front page, front page, covered on but without a 
pointer to the patch, and so on.  So this post provides a subject line 
for Google to find, and for good measure mentions the word 


I think many users would first go to on a day like today, as 
I did.  Nothing to see there.  We could do a way better job of getting 
the word out.

Patch attached as posted above by Pekka.  For the mortals among us:

   cd linux-2.6.recent && patch <fix.vmsplice.exploit.patch -p1



[-- Attachment #2: fix.vmsplice.exploit.patch --]
[-- Type: text/x-diff, Size: 751 bytes --]

Cc: <>
Cc: Jens Axboe <>
Cc: Andrew Morton <>
Signed-off-by: Pekka Enberg <>
Bastian, can I have your Signed-off-by for this, please? Oliver, Niki, can 
you please confirm this closes the hole?

 fs/splice.c |    3 +++
 1 file changed, 3 insertions(+)

Index: linux-2.6/fs/splice.c
--- linux-2.6.orig/fs/splice.c
+++ linux-2.6/fs/splice.c
@@ -1237,6 +1237,9 @@ static int get_iovec_page_array(const st
 		if (unlikely(!base))
+		if (unlikely(!access_ok(VERIFY_READ, base, len)))
+			break;
 		 * Get this base offset and number of pages, then map
 		 * in the user pages.

  parent reply	other threads:[~2008-02-11  7:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-10 14:47 [PATCH] splice: fix user pointer access in get_iovec_page_array() Pekka J Enberg
2008-02-10 15:17 ` Bastian Blank
2008-02-10 15:31   ` Oliver Pinter
2008-02-10 23:37 ` Willy Tarreau
2008-02-11  6:24   ` Oliver Pinter
2008-02-11  7:29 ` Daniel Phillips [this message]
2008-02-11  7:49   ` [PATCH] vmsplice exploit fix (was: splice: fix user pointer access in get_iovec_page_array) Pekka Enberg
2008-02-11  8:00     ` Daniel Phillips
2008-02-11  7:53   ` [stable] " Greg KH
2008-02-11  8:05     ` Daniel Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] vmsplice exploit fix (was: splice: fix user pointer access in get_iovec_page_array)' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).