LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Documentation: prune redundant SubmitChecklist items
@ 2008-02-10 23:48 J. Bruce Fields
0 siblings, 0 replies; only message in thread
From: J. Bruce Fields @ 2008-02-10 23:48 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
From: J. Bruce Fields <email@example.com>
Kernel style is mentioned twice, and the git apply trick is a bit
redundant given the checkpatch.pl recommendation (which also checks for
Signed-off-by: J. Bruce Fields <firstname.lastname@example.org>
Documentation/SubmitChecklist | 16 +++++-----------
1 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/Documentation/SubmitChecklist b/Documentation/SubmitChecklist
index 34e06d2..da10e07 100644
@@ -20,7 +20,11 @@ kernel patches.
4: ppc64 is a good architecture for cross-compilation checking because it
tends to use `unsigned long' for 64-bit quantities.
-5: Matches kernel coding style(!)
+5: Check your patch for general style as detailed in
+ Documentation/CodingStyle. Check for trivial violations with the
+ patch style checker prior to submission (scripts/checkpatch.pl).
+ You should be able to justify all violations that remain in
+ your patch.
6: Any new or modified CONFIG options don't muck up the config menu.
@@ -79,13 +83,3 @@ kernel patches.
23: Tested after it has been merged into the -mm patchset to make sure
that it still works with all of the other queued patches and various
changes in the VM, VFS, and other subsystems.
-24: Avoid whitespace damage such as indenting with spaces or whitespace
- at the end of lines. You can test this by feeding the patch to
- "git apply --check --whitespace=error-all"
-25: Check your patch for general style as detailed in
- Documentation/CodingStyle. Check for trivial violations with the
- patch style checker prior to submission (scripts/checkpatch.pl).
- You should be able to justify all violations that remain in
- your patch.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-02-10 23:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-10 23:48 [PATCH] Documentation: prune redundant SubmitChecklist items J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).