LKML Archive on
help / color / mirror / Atom feed
From: "S.Çağlar Onur" <>
To: Jiri Slaby <>
Subject: Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)
Date: Mon, 11 Feb 2008 01:44:05 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>


10 Şub 2008 Paz tarihinde, Jiri Slaby şunları yazmıştı: 
> I think this is not correct. You change the err which caused the failure. You 
> change it even to 0 if it doesn't fail and the whole function will seem like 
> non-failing.

My bad, sorry for not looking carefully. Assuming a refactoring is not desired for just a compiler warning, is following acceptable (this kind of plain messages seems heavily used in vmt.c, so i'm again assuming its OK to use such style)?

commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images) introduced the warning

drivers/mtd/ubi/vmt.c: In function `ubi_create_volume':
drivers/mtd/ubi/vmt.c:379: warning: statement with no effect

 drivers/mtd/ubi/vmt.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
index a3ca225..46410f6 100644
--- a/drivers/mtd/ubi/vmt.c
+++ b/drivers/mtd/ubi/vmt.c
@@ -376,7 +376,8 @@ out_sysfs:
-	ubi_destroy_gluebi(vol);
+	if(ubi_destroy_gluebi(vol))
+		ubi_err("cannot destroy device");

S.Çağlar Onur <>

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!

  reply	other threads:[~2008-02-10 23:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-10  3:37 S.Çağlar Onur
2008-02-10  8:39 ` Jiri Slaby
2008-02-10 23:44   ` S.Çağlar Onur [this message]
2008-02-12  9:33     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).