LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Whitcroft <apw@shadowen.org>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: bug in checkpatch (on pointers to typedefs?)
Date: Mon, 11 Feb 2008 10:23:39 +0000	[thread overview]
Message-ID: <20080211102339.GD11671@shadowen.org> (raw)
In-Reply-To: <20080210143240.GA13317@joi>

On Sun, Feb 10, 2008 at 03:33:02PM +0100, Marcin Slusarz wrote:
> Hi
> 
> Checkpatch in current mainline outputs following errors:
> 
> $ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #205: FILE: fs/udf/misc.c:205:
> +       tag *tag_p;
>             ^
> 
> $ ./scripts/checkpatch.pl -q --file ./fs/udf/unicode.c
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #48: FILE: fs/udf/unicode.c:48:
> +int udf_build_ustr(struct ustr *dest, dstring *ptr, int size)
>                                                ^
> (...)
> 
> I think the code is ok.

Yep the code is clearly correct.  Can I have the whole patch fragment
you got these against so I can figure out why we are unable to detect
these two as types, I would expect us to have done so.  Also what
version of checkpatch is this?  There is a version string at the top.

-apw

  reply	other threads:[~2008-02-11 10:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-10 14:33 Marcin Slusarz
2008-02-11 10:23 ` Andy Whitcroft [this message]
2008-02-11 16:05   ` Benny Halevy
2008-02-11 16:40     ` Andy Whitcroft
2008-02-11 16:58       ` Benny Halevy
2008-02-11 18:42         ` Andy Whitcroft
2008-02-12  8:21           ` Benny Halevy
2008-02-11 18:09   ` Marcin Slusarz
2008-02-13 19:43 ` Jan Engelhardt
2008-02-14 10:06   ` Andy Whitcroft
2008-02-14 18:29     ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080211102339.GD11671@shadowen.org \
    --to=apw@shadowen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.slusarz@gmail.com \
    --subject='Re: bug in checkpatch (on pointers to typedefs?)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).