LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH][RESEND] drivers/base: export (un)register_memory_notifier
@ 2008-02-11  9:49 Jan-Bernd Themann
  2008-02-11 10:12 ` Dave Hansen
  0 siblings, 1 reply; 4+ messages in thread
From: Jan-Bernd Themann @ 2008-02-11  9:49 UTC (permalink / raw)
  To: Greg KH
  Cc: Jan-Bernd Themann, Thomas Klein, netdev, linux-kernel, linux-ppc,
	Christoph Raisch

Drivers like eHEA need memory notifiers in order to 
update their internal DMA memory map when memory is added
to or removed from the system.

Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>

---
Hi Greg,

are you the right person to address this patch to?

Regards,
Jan-Bernd

 drivers/base/memory.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index 7ae413f..1e1bd4c 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
 {
         return blocking_notifier_chain_register(&memory_chain, nb);
 }
+EXPORT_SYMBOL(register_memory_notifier);
 
 void unregister_memory_notifier(struct notifier_block *nb)
 {
         blocking_notifier_chain_unregister(&memory_chain, nb);
 }
+EXPORT_SYMBOL(unregister_memory_notifier);
 
 /*
  * register_memory - Setup a sysfs device for a memory block
-- 
1.5.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier
  2008-02-11  9:49 [PATCH][RESEND] drivers/base: export (un)register_memory_notifier Jan-Bernd Themann
@ 2008-02-11 10:12 ` Dave Hansen
  2008-02-11 10:47   ` Jan-Bernd Themann
  0 siblings, 1 reply; 4+ messages in thread
From: Dave Hansen @ 2008-02-11 10:12 UTC (permalink / raw)
  To: Jan-Bernd Themann
  Cc: Greg KH, Jan-Bernd Themann, Thomas Klein, netdev, linux-kernel,
	linux-ppc, Christoph Raisch

On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote:
> are you the right person to address this patch to?

You might want to check the top of the file. ;)

> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
>  {
>          return blocking_notifier_chain_register(&memory_chain, nb);
>  }
> +EXPORT_SYMBOL(register_memory_notifier);
>  
>  void unregister_memory_notifier(struct notifier_block *nb)
>  {
>          blocking_notifier_chain_unregister(&memory_chain, nb);
>  }
> +EXPORT_SYMBOL(unregister_memory_notifier);

Is there a particular reason these can't be GPL?

-- Dave


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier
  2008-02-11 10:12 ` Dave Hansen
@ 2008-02-11 10:47   ` Jan-Bernd Themann
  2008-02-11 15:22     ` Greg KH
  0 siblings, 1 reply; 4+ messages in thread
From: Jan-Bernd Themann @ 2008-02-11 10:47 UTC (permalink / raw)
  To: Dave Hansen
  Cc: Greg KH, Jan-Bernd Themann, Thomas Klein, netdev, linux-kernel,
	linux-ppc, Christoph Raisch

On Monday 11 February 2008 11:12, Dave Hansen wrote:
> On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote:
> > are you the right person to address this patch to?
> 
> You might want to check the top of the file. ;)
> 
> > --- a/drivers/base/memory.c
> > +++ b/drivers/base/memory.c
> > @@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
> >  {
> >          return blocking_notifier_chain_register(&memory_chain, nb);
> >  }
> > +EXPORT_SYMBOL(register_memory_notifier);
> >  
> >  void unregister_memory_notifier(struct notifier_block *nb)
> >  {
> >          blocking_notifier_chain_unregister(&memory_chain, nb);
> >  }
> > +EXPORT_SYMBOL(unregister_memory_notifier);
> 
> Is there a particular reason these can't be GPL?
> 

I don't object to make them GPL. Greg, what do you think?

Regards,
Jan-Bernd


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][RESEND] drivers/base: export (un)register_memory_notifier
  2008-02-11 10:47   ` Jan-Bernd Themann
@ 2008-02-11 15:22     ` Greg KH
  0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2008-02-11 15:22 UTC (permalink / raw)
  To: Jan-Bernd Themann
  Cc: Dave Hansen, Jan-Bernd Themann, Thomas Klein, netdev,
	linux-kernel, linux-ppc, Christoph Raisch

On Mon, Feb 11, 2008 at 11:47:50AM +0100, Jan-Bernd Themann wrote:
> On Monday 11 February 2008 11:12, Dave Hansen wrote:
> > On Mon, 2008-02-11 at 10:49 +0100, Jan-Bernd Themann wrote:
> > > are you the right person to address this patch to?
> > 
> > You might want to check the top of the file. ;)
> > 
> > > --- a/drivers/base/memory.c
> > > +++ b/drivers/base/memory.c
> > > @@ -52,11 +52,13 @@ int register_memory_notifier(struct notifier_block *nb)
> > >  {
> > >          return blocking_notifier_chain_register(&memory_chain, nb);
> > >  }
> > > +EXPORT_SYMBOL(register_memory_notifier);
> > >  
> > >  void unregister_memory_notifier(struct notifier_block *nb)
> > >  {
> > >          blocking_notifier_chain_unregister(&memory_chain, nb);
> > >  }
> > > +EXPORT_SYMBOL(unregister_memory_notifier);
> > 
> > Is there a particular reason these can't be GPL?
> > 
> 
> I don't object to make them GPL. Greg, what do you think?

They should be _GPL to match the rest of the driver core.

Care to resend this?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-02-11 15:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-11  9:49 [PATCH][RESEND] drivers/base: export (un)register_memory_notifier Jan-Bernd Themann
2008-02-11 10:12 ` Dave Hansen
2008-02-11 10:47   ` Jan-Bernd Themann
2008-02-11 15:22     ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).